-
Notifications
You must be signed in to change notification settings - Fork 183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add bind support #493
Merged
Merged
Add bind support #493
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: sanyangji <songyujie@zju.edu.cn>
Signed-off-by: sanyangji <songyujie@zju.edu.cn>
Signed-off-by: sanyangji <songyujie@zju.edu.cn>
Signed-off-by: sanyangji <songyujie@zju.edu.cn>
Signed-off-by: sanyangji <songyujie@zju.edu.cn>
dxsup
reviewed
Mar 27, 2023
dxsup
reviewed
Mar 27, 2023
probe/src/cgo/kindling.cpp
Outdated
Comment on lines
320
to
321
case SCAP_FD_IPV6_SERVSOCK: | ||
p_kindling_event->context.fdInfo.role = fdInfo->is_role_server(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why don't set p_kindling_event->context.fdInfo.protocol = get_protocol(fdInfo->get_l4proto());
Signed-off-by: sanyangji <songyujie@zju.edu.cn>
dxsup
approved these changes
Mar 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Support syscall bind: set the socket address to FdInfo.
Reuse
dip
anddport
to store server's listening ip and port.Motivation and Context
The main motivation is that syscall bind will bind the address to type SCAP_FD_IPV4_SERVSOCK, which has not support yet.
How Has This Been Tested?
Trigger bind syscall and part of test log as: