Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the potential endless loop in the rocketmq parser #465

Merged
merged 2 commits into from
Feb 28, 2023
Merged

Fix the potential endless loop in the rocketmq parser #465

merged 2 commits into from
Feb 28, 2023

Conversation

dxsup
Copy link
Member

@dxsup dxsup commented Feb 28, 2023

Description

Fix the potential endless loop in the rocketmq parser.

How Has This Been Tested?

Before

=== RUN   Test_parseHeader
    rocketmq_request_test.go:43: The test case didn't finish in 5 seconds.
--- FAIL: Test_parseHeader (5.00s)
testing: warning: no tests to run
=== RUN   Test_parseHeader/busy-loop
FAIL

After

=== RUN   Test_parseHeader
=== RUN   Test_parseHeader/busy-loop
--- PASS: Test_parseHeader (0.00s)
    --- PASS: Test_parseHeader/busy-loop (0.00s)
PASS

Fix the potential endless loop in the rocketmq parser
b689e69 
Signed-off-by: Daxin Wang <daxinwang@harmonycloud.cn>
@dxsup dxsup requested a review from hocktea214 February 28, 2023 06:48
hocktea214
hocktea214 previously approved these changes Feb 28, 2023
View reviewed changes
Update the CHANGELOG.md
816f351 
Signed-off-by: Daxin Wang <daxinwang@harmonycloud.cn>
@dxsup dxsup merged commit 44fc757 into KindlingProject:main Feb 28, 2023
@dxsup dxsup deleted the fix-rocketmq branch February 28, 2023 07:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hocktea214 hocktea214 hocktea214 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dxsup @hocktea214