FIX http-100 request is detected as NOSUPPORT #393
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: huxiangyuan <huxiangyuan@harmonycloud.cn>
Signed-off-by: huxiangyuan <huxiangyuan@harmonycloud.cn>
dxsup
reviewed
Dec 13, 2022
dxsup
reviewed
Dec 13, 2022
collector/pkg/component/analyzer/network/protocol/testdata/dubbo/server-trace-short.yml
Show resolved
Hide resolved
collector/pkg/component/analyzer/network/protocol/http/http_response.go
Outdated
Show resolved
Hide resolved
Signed-off-by: huxiangyuan <huxiangyuan@harmonycloud.cn>
dxsup
previously approved these changes
Dec 13, 2022
dxsup
approved these changes
Dec 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: huxiangyuan huxiangyuan@harmonycloud.cn
Description
A big request is splitted to 100-continue requests, only the first request is detected as http, others are detected as NOSUPPORT
Related Issue
Parse HTTP protocol bug with the response status code 100 #388
Motivation and Context
How Has This Been Tested?
Add testCase TestHttpProtocol/continueData for HTTP/100
=== RUN TestHttpProtocol/continueData
--- PASS: TestHttpProtocol (0.01s)
--- PASS: TestHttpProtocol/continueData (0.00s)