Remove "reset" method of ScheduledTaskRoutine to fix bugs #369
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NeJan2020
added
the
area/collector
dxsup
force-pushed
the
fix/timer-block
branch
3 times, most recently
from
43ceaa2 to
14a6e45
Compare
hocktea214
previously approved these changes
Dec 6, 2022
added 4 commits
December 6, 2022 09:42
Signed-off-by: Daxin Wang <daxinwang@harmonycloud.cn>
… of "timer" Signed-off-by: Daxin Wang <daxinwang@harmonycloud.cn>
Signed-off-by: Daxin Wang <daxinwang@harmonycloud.cn>
Signed-off-by: Daxin Wang <daxinwang@harmonycloud.cn>
dxsup
force-pushed
the
fix/timer-block
branch
from
14a6e45 to
32f66e6
Compare
hocktea214
approved these changes
Dec 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Due to the incorrect usage of "time.Timer", the scheduled routines may block the main thread. After reviewing the code, I found the "reset" method which incorrectly uses "time.Timer" also introduces a bug when exporting cpuEvents to files. This method is unnecessary any more, so I delete it. This can resolve two bugs together.
Related Issue
#370