-
Notifications
You must be signed in to change notification settings - Fork 183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Modify the configuration file structure and add parameter fields for subscription events #368
Conversation
6066d6b
to
eb04934
Compare
Signed-off-by: yaofighting <siyao@zju.edu.cn>
f82968b
to
84fa5f4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
We may unify the Naming Convention for cpp codes and cgo codes.
@dxsup @jundizhou
Signed-off-by: yaofighting <siyao@zju.edu.cn>
For example? I didn't see any difference on "Naming Convention" between these files. Do you mean the indentation style? |
|
OK, so first let's determine the convention on naming, then we can rename them all. |
We can open another PR for the "naming convention". Back to this one, LGTM. |
I think we should use underscore_case in C/C++ and camelCase in Golang. |
1 similar comment
I think we should use underscore_case in C/C++ and camelCase in Golang. |
Signed-off-by: yaofighting <siyao@zju.edu.cn>
Modify the configuration file structure and add parameter fields for subscription events
Signed-off-by: yaofighting siyao@zju.edu.cn
Motivation
In some scenarios, only specifying the type of subscription event cannot meet our needs. Therefore, we need to enhance the features of the subscription part, support more detailed parameter lists, and control the CPP side to send only the event information we are concerned about to the Go side. For example, we need to specify system calls that filter latency is less than 500ms. When subscribing to events, we tell the CPP side to send only data that meets this condition, so as to avoid performance loss caused by data filtering on the Go side.
Related Issue
#366