Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify the configuration file structure and add parameter fields for subscription events #368

Merged
merged 3 commits into from
Dec 2, 2022

Conversation

yaofighting
Copy link
Contributor

@yaofighting yaofighting commented Nov 23, 2022

Modify the configuration file structure and add parameter fields for subscription events

Signed-off-by: yaofighting siyao@zju.edu.cn

Motivation

In some scenarios, only specifying the type of subscription event cannot meet our needs. Therefore, we need to enhance the features of the subscription part, support more detailed parameter lists, and control the CPP side to send only the event information we are concerned about to the Go side. For example, we need to specify system calls that filter latency is less than 500ms. When subscribing to events, we tell the CPP side to send only data that meets this condition, so as to avoid performance loss caused by data filtering on the Go side.

Related Issue

#366

Signed-off-by: yaofighting <siyao@zju.edu.cn>
@yaofighting yaofighting force-pushed the support_config_params branch from f82968b to 84fa5f4 Compare November 30, 2022 06:40
sanyangji
sanyangji previously approved these changes Dec 1, 2022
Copy link
Collaborator

@sanyangji sanyangji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
We may unify the Naming Convention for cpp codes and cgo codes.
@dxsup @jundizhou

CHANGELOG.md Outdated Show resolved Hide resolved
Signed-off-by: yaofighting <siyao@zju.edu.cn>
@dxsup
Copy link
Member

dxsup commented Dec 1, 2022

LGTM.
We may unify the Naming Convention for cpp codes and cgo codes.
@dxsup @jundizhou

For example? I didn't see any difference on "Naming Convention" between these files. Do you mean the indentation style?

@sanyangji
Copy link
Collaborator

LGTM.
We may unify the Naming Convention for cpp codes and cgo codes.
@dxsup @jundizhou

For example? I didn't see any difference on "Naming Convention" between these files. Do you mean the indentation style?

void sub_event(char* eventName, char* category, event_params_for_subscribe params[]) Like In this line, eventName is different from others

@dxsup
Copy link
Member

dxsup commented Dec 1, 2022

OK, so first let's determine the convention on naming, then we can rename them all.

sanyangji
sanyangji previously approved these changes Dec 1, 2022
@dxsup
Copy link
Member

dxsup commented Dec 1, 2022

We can open another PR for the "naming convention". Back to this one, LGTM.

dxsup
dxsup previously approved these changes Dec 1, 2022
@yaofighting
Copy link
Contributor Author

I think we should use underscore_case in C/C++ and camelCase in Golang.

1 similar comment
@yaofighting
Copy link
Contributor Author

I think we should use underscore_case in C/C++ and camelCase in Golang.

Signed-off-by: yaofighting <siyao@zju.edu.cn>
@yaofighting yaofighting dismissed stale reviews from dxsup and sanyangji via 69a9582 December 1, 2022 12:51
@dxsup dxsup requested a review from sanyangji December 2, 2022 03:18
@dxsup dxsup merged commit 10ca120 into KindlingProject:main Dec 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants