Avoid printing logs to console when both the log levels of observability are set to none #316
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: niejiangang <niejiangang@harmonycloud.cn>
Signed-off-by: niejiangang <niejiangang@harmonycloud.cn>
Signed-off-by: niejiangang <niejiangang@harmonycloud.cn>
dxsup
approved these changes
Sep 19, 2022
NeJan2020
changed the title
observability.logger.file_level and observability.logger.console_level are set to none
NeJan2020
changed the title
observability.logger.file_level and observability.logger.console_level are set to none
NeJan2020
changed the title
NeJan2020
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes the performance of the
observabilitymore reasonable when bothobservability.logger.file_levelandobservability.logger.console_levelis set tonone.Kindling will only export the log to the console at Panic Level after this PR.
However, some logs will still output to the console when the agent starts since they are not controlled by observability， such as Probe's log.