Allow the collector run in the non-Kubernetes environment #285
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
July 1, 2022 10:38
Signed-off-by: Daxin Wang <daxinwang@harmonycloud.cn>
Signed-off-by: Daxin Wang <daxinwang@harmonycloud.cn>
Signed-off-by: Daxin Wang <daxinwang@harmonycloud.cn>
Signed-off-by: Daxin Wang <daxinwang@harmonycloud.cn>
Signed-off-by: Daxin Wang <daxinwang@harmonycloud.cn>
dxsup
force-pushed
the
allow-run-non-kubernetes-env
branch
from
94251d6 to
247ddb4
Compare
Signed-off-by: Daxin Wang <daxinwang@harmonycloud.cn>
NeJan2020
approved these changes
Jul 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add a
disableoption, which isfalseby default, to the configuration of thekubernetesprocessor. If it is true, thekubernetesprocessorwon't try to connect to the Kubernetes API-server and will just send thedataGroupsit consumes to the next consumer.Motivation and Context
Some users want to run the collector in the non-Kubernetes environment.
There is also another implementation that meets the requirement. If the
kubernetesprocessorfails to connect the API-server when initializing, we don't panic the process and just send the data to the next consumer later. In this way, no option is added. But the problem is that the users don't know whether the connection is ok. By explicitly setting thedisableoption, the users know the behavior of the processor. So I prefer panicking the process to letting it run if the connection failed and the option is not set, in which way the users could know exactly what happened.