update: use cgo instead of uds #264
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: sangyangji <songyujie@zju.edu.cn>
Signed-off-by: jundizhou <jundizhou@harmonycloud.cn>
Signed-off-by: Daxin Wang <daxinwang@harmonycloud.cn>
convert the cgo event to the KindlingEvent
Signed-off-by: Daxin Wang <daxinwang@harmonycloud.cn>
using a channel to store the events
Signed-off-by: jundizhou <jundizhou@harmonycloud.cn>
Signed-off-by: Daxin Wang <daxinwang@harmonycloud.cn>
NeJan2020
reviewed
Jun 27, 2022
Comment on lines
+80
to
+93
| func (r *CgoReceiver) printMetrics() { | ||
| timer := time.NewTicker(1 * time.Second) | ||
| r.shutdownWG.Add(1) | ||
| for { | ||
| select { | ||
| case <-r.stopCh: | ||
| r.shutdownWG.Done() | ||
| return | ||
| case <-timer.C: | ||
| r.telemetry.Logger.Info("Total number events received: ", zap.Int("events", r.eventCount)) | ||
| r.eventCount = 0 | ||
| r.telemetry.Logger.Info("Current channel size: ", zap.Int("channel size", len(r.eventChannel))) | ||
| } | ||
| } |
There was a problem hiding this comment.
Was that necessary to print this Metric every second
There was a problem hiding this comment.
No, I will open another PR to introduce opentelemetry to record metrics.
Signed-off-by: Daxin Wang <daxinwang@harmonycloud.cn>
NeJan2020
reviewed
Jun 27, 2022
deploy/agent/kindling-deploy.yml
Outdated
Comment on lines
47
to
50
| - cat | ||
| - /opt/kernel-support | ||
| initialDelaySeconds: 5 | ||
| periodSeconds: 5 | ||
| - cat | ||
| - /opt/kernel-support |
There was a problem hiding this comment.
Why not keep the initialDelaySeconds and periodSeconds?
NeJan2020
reviewed
Jun 27, 2022
Comment on lines
+3
to
+5
| cd probe/build | ||
| cmake -DBUILD_DRIVER=OFF -DPROBE_VERSION=0.1.1dev .. | ||
| make |
There was a problem hiding this comment.
It seems we have to set the PROBE_VERSION manually.
There was a problem hiding this comment.
There will be another PR to improve it.
NeJan2020
reviewed
Jun 27, 2022
deploy/scripts/build.sh
Outdated
Comment on lines
13
to
16
| cd ../../collector/ | ||
| go build | ||
| collectorPath="./collector" | ||
| if [ ! -f "$collectorPath" ]; then |
There was a problem hiding this comment.
We need the CodeVersion of the collector either.
There was a problem hiding this comment.
Using the collector-version-build.sh to replace go build
NeJan2020
reviewed
Jun 27, 2022
deploy/agent/kindling-deploy.yml
Outdated
Comment on lines
19
to
21
| - name: kindling-probe | ||
| image: kindlingproject/kindling-probe:latest | ||
| - name: kindling-collector | ||
| image: registry.cn-hangzhou.aliyuncs.com/zjd-kindling/zjdkindling:new1 | ||
| imagePullPolicy: Always |
There was a problem hiding this comment.
We should not use a personal image
added 3 commits
June 27, 2022 17:24
Signed-off-by: Daxin Wang <daxinwang@harmonycloud.cn>
Signed-off-by: Daxin Wang <daxinwang@harmonycloud.cn>
Signed-off-by: Daxin Wang <daxinwang@harmonycloud.cn>
dxsup
approved these changes
Jun 27, 2022
NeJan2020
approved these changes
Jun 27, 2022
This was referenced Jun 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
probe:
Sending data using CGO mode
Update struct of kindlingEvent
Remove probe Dockerfile
Remove probe compiler's scripts
Use cmake instead of bazel
collector:
Receiver data using CGO mode
Update Dockerfile
Update compiler scripts
How Has This Been Tested?
recompiler and test all
for issue #265