Add TCP connect metrics #234
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 11 commits
June 1, 2022 17:49
Signed-off-by: Daxin Wang <daxinwang@harmonycloud.cn>
Signed-off-by: Daxin Wang <daxinwang@harmonycloud.cn>
Signed-off-by: Daxin Wang <daxinwang@harmonycloud.cn>
Signed-off-by: Daxin Wang <daxinwang@harmonycloud.cn>
Signed-off-by: Daxin Wang <daxinwang@harmonycloud.cn>
Signed-off-by: Daxin Wang <daxinwang@harmonycloud.cn>
# Conflicts: # collector/receiver/udsreceiver/udsreceiver.go
Signed-off-by: Daxin Wang <daxinwang@harmonycloud.cn>
Signed-off-by: Daxin Wang <daxinwang@harmonycloud.cn>
Signed-off-by: Daxin Wang <daxinwang@harmonycloud.cn>
Signed-off-by: Daxin Wang <daxinwang@harmonycloud.cn>
Signed-off-by: Daxin Wang <daxinwang@harmonycloud.cn>
|
Can you update PrometheusMetric doc for this metric? |
|
OK, I will. |
…shed Signed-off-by: Daxin Wang <daxinwang@harmonycloud.cn>
NeJan2020
reviewed
Jun 1, 2022
collector/analyzer/tcpconnectanalyzer/internal/connect_monitor.go
Outdated
Show resolved
Hide resolved
Signed-off-by: Daxin Wang <daxinwang@harmonycloud.cn>
NeJan2020
reviewed
Jun 2, 2022
collector/analyzer/tcpconnectanalyzer/internal/connect_monitor.go
Outdated
Show resolved
Hide resolved
Signed-off-by: Daxin Wang <daxinwang@harmonycloud.cn>
NeJan2020
reviewed
Jun 2, 2022
added 2 commits
June 2, 2022 10:39
Signed-off-by: Daxin Wang <daxinwang@harmonycloud.cn>
Signed-off-by: Daxin Wang <daxinwang@harmonycloud.cn>
NeJan2020
previously approved these changes
Jun 2, 2022
Signed-off-by: Daxin Wang <daxinwang@harmonycloud.cn>
NeJan2020
approved these changes
Jun 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Implement TCP connect metrics including:
kindling_tcp_connect_totalkindling_tcp_connect_duration_nanoseconds_totalBesides, I also added a new telemetry metric
kindling_telemetry_tcpconnectanalyzer_map_sizefor monitoring the map size of thetcpconnectanalyzer.Related Issue
This is the implementation for analyzing the events that emitted via #131.