Decouple the logic of dispatching events from receivers #232
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
June 1, 2022 15:35
…nager Signed-off-by: Daxin Wang <daxinwang@harmonycloud.cn>
Signed-off-by: Daxin Wang <daxinwang@harmonycloud.cn>
Signed-off-by: Daxin Wang <daxinwang@harmonycloud.cn>
NeJan2020
reviewed
Jun 1, 2022
added 2 commits
June 1, 2022 18:03
Signed-off-by: Daxin Wang <daxinwang@harmonycloud.cn>
Signed-off-by: Daxin Wang <daxinwang@harmonycloud.cn>
NeJan2020
approved these changes
Jun 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I have removed the logic of dispatching events from receivers so that now receivers don't care about the analyzers after the initialization. All changes about dispatching events are limited in the analyzers.
AnalyzerManager now takes a more important responsibility for creating the dispatching logic.
Motivation and Context
In the current implementation, we can't send an event to different analyzers, which is necessary for implementing another metric(TCP connect metrics which I'm working on). This PR allows the receivers to do that.
Test
=== RUN TestNewManager
--- PASS: TestNewManager (0.00s)
PASS