Impl trait edits #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kimundi
pushed a commit
that referenced
this pull request
Nov 12, 2016
Kimundi
pushed a commit
that referenced
this pull request
Nov 12, 2016
Refine rough edges wrt coercion
Kimundi
pushed a commit
that referenced
this pull request
Nov 12, 2016
Make this RFC be again about a single method
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@Kimundi, sorry for the long delay on this, but here are my edits. I filled in the motivation section largely with old text. But I also did quite a bit of restructuring and some rewriting of the rest of the RFC. None of the details about the proposal have changed; it's all focused on discussion of rationale etc.
I removed the unresolved question you had, because I believe it's just fine -- let's chat about it on IRC soon.
If you are happy with this and want to merge, I think you can go ahead and open the RFC as well.
FWIW, I think I want to argue that we should include
@Traitin argument position in this RFC as well, but I'm happy to do that on thread.Thanks again for putting this together!
cc @eddyb