Make twox-hash an optional dependency #53
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a new feature "hash" which pulls in twox-hash and hashes during decoding. Add "hash" to default features. Fixes KillingSpark#52.
tamird
changed the title
|
Looks good! Any reason to change the Hasher initialization from the explicit seed to Default::default? I think it's better to have the explicit thing to make sure we stay spec compliant even if the default seed changes |
The only reason was to reduce the number of references to the twox_hash type. I'm not at a computer for a bit but feel free to amend! |
|
Thanks! Did the amend and merged :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a new feature "hash" which pulls in twox-hash and hashes during
decoding. Add "hash" to default features.
Fixes #52.