Replace xxhash with ahash #51
Conversation
ahash is much more widely used and claims to be a good bit faster.
|
I'm sorry if I am just confused, but ahash is different from xxhash right? (Based on all the test files failing with wrong checksums I guess it is) The xxhash algorithm is required by the zstd spec for the checksums, this wasn't my choice |
|
Yeah, I see that now. I'm trying to move xxhash to a dev dependency, would you accept that change? |
|
Oof, that is seeming pretty difficult given how much Well, it'd be good to make xxhash a dev-dependency, but I guess I won't be doing that here. |
|
Sorry I should have clarified, xxhash is an integral part of the zsdt format. The checksums that are part of the frame definition are calculated that way. You need this if you want to make sure you decoded the correct data, which is probably what you want to do in many cases |
ahash is much more widely used and claims to be a good bit faster.