Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Battle Group Spawning + AI #942

Merged
merged 9 commits into from
Mar 15, 2024
Merged

Battle Group Spawning + AI #942

merged 9 commits into from
Mar 15, 2024

Conversation

some-evil-kitty
Copy link
Collaborator

@some-evil-kitty some-evil-kitty commented Oct 21, 2023

Q A
Bug fix? yes
New feature? no
Needs wipe? no

Description:

Content:

  • Server Event
  • LAMBS function
  • Battlegroup tagging

Successfully tested on:

  • Local MP
  • Dedicated MP

Fixed infantry battlegroups to not "lose" members, enable lambs reinforcements on them, change "reset" listener to server event
spawn returns a script handle, not a vehicle, meaning vehicle battlegroups lose track of their spawned vehicles
carlmylo added a commit to moistbois/Moist-Liberation-APR that referenced this pull request Nov 15, 2023
Originally from: KillahPotatoes#942

Co-Authored-By: some-evil-kitty <106408180+some-evil-kitty@users.noreply.github.com>
@veteran29 veteran29 self-requested a review November 24, 2023 03:36
ralreegorganon pushed a commit to ralreegorganon/KP-Liberation that referenced this pull request Dec 2, 2023
Originally from: KillahPotatoes#942

Co-Authored-By: some-evil-kitty <106408180+some-evil-kitty@users.noreply.github.com>
Crowdedlight added a commit to Crowdedlight/KP-Liberation-war-room that referenced this pull request Mar 4, 2024
Copy link
Member

@veteran29 veteran29 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One behaviour question.

Please try to keep indentation consistent in the codebase as it makes it easier to do code reviews.

Co-authored-by: Filip Maciejewski <veteran29@users.noreply.github.com>
My bad
Copy link
Member

@veteran29 veteran29 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@some-evil-kitty some-evil-kitty merged commit 86d299c into v0.96.8 Mar 15, 2024
1 check passed
@some-evil-kitty some-evil-kitty deleted the battlegroup-ai branch March 15, 2024 00:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants