Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes reference to GetAddOnMetadata for 11.0.2 #38

Merged
merged 1 commit into from
Aug 17, 2024
Merged

Conversation

icbat
Copy link

@icbat icbat commented Aug 13, 2024

These can be seen on first login with ChocolateBar installed after 11.0.2 was applied. These changes have fixed them for me and survived a basic smoke test of the addon.

Should fix #39 and #40, though as cremor points out below, there's also a fix needed in modules\MicroMenu\Options.lua

@akgis32
Copy link

akgis32 commented Aug 14, 2024

Thanks applyed localy and can attest that its working so far

@LootFever
Copy link

LootFever commented Aug 15, 2024

I would implore to roll out this fix asap. If you already are packaging etc (I'm clueless in that regard) ignore my comment.
There might be more LUA errors atm but this fix alone made the bar visible (and as far as I can tell working) again.

@cremor
Copy link

cremor commented Aug 15, 2024

@icbat There is another call in modules\MicroMenu\Options.lua

@icbat
Copy link
Author

icbat commented Aug 15, 2024

@icbat There is another call in modules\MicroMenu\Options.lua

You know, I see that in the version I have downloaded, but I don't see that file in this branch/repo. We'll probably have to wait for the repo owner to weigh in/help a bit.

@cremor
Copy link

cremor commented Aug 15, 2024

Oh, I see. It's pulled in via .pkgmeta from https://github.com/Kiatra/Broker_MicroMenu

@Kiatra Kiatra merged commit 35da0f8 into Kiatra:master Aug 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug Report] Multiple LUA errors with WoW patch 11.0.2.56011
5 participants