Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

write_gif() ImageMagick fix #1

Merged
merged 1 commit into from
Jun 15, 2019
Merged

write_gif() ImageMagick fix #1

merged 1 commit into from
Jun 15, 2019

Conversation

KiLLAAA
Copy link
Owner

@KiLLAAA KiLLAAA commented Jun 14, 2019

write_gif() fuzz argument had no visible influence on output file due to wrong order of params passsed to ImageMagick, these changes fixed this issue. Optimizations work now too.
Changes are made accordingly to ImageMagick usage documentation.
test snippet:
`
from moviepy.editor import *

clip = (VideoFileClip(infile, audio=False))
clip.write_gif('test.gif', fps=15, program='ImageMagick', fuzz=40, opt='optimize-frame')
`

  • If this is a bugfix, I have provided code that clearly demonstrates the problem and that works when used with this PR
  • I have added a test to the test suite, if necessary
  • I have properly documented new or changed features in the documention, or the docstrings
  • I have properly documented unusual changes to the code in the comments around it
  • I have made note of any breaking/backwards incompatible changes

Fuzz option "does nothing" to output file due to wrong order of params passsed to ImageMagick, these changes fix this issue.
@KiLLAAA KiLLAAA merged commit 1656658 into master Jun 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant