-
Notifications
You must be signed in to change notification settings - Fork 739
Conversation
I had mis-remembered this rule
The CI failures are OK, I believe. |
A few questions & remarks:
|
|
I re-checked the pin-types of the 'controversial' pins. The block-diagram arrows and the pin-table don't always match. And then there is also the example application (e.g. 10.2.1). Regarding the layout: So in conclusion, I am happy to merge as is. Or is there anything else? |
Thanks for looking again! I can change things. It doesn't have to be this way. Maybe The footprint needs to be merged before this. And that depends on KiCad/kicad-footprints#955. Sigh. |
Submitted the footprint at KiCad/kicad-footprints#2468. |
Closing/opening to refresh the Travis test. |
@cpresser the footprint has been merged |
I fixed the footprint name referenced by the symbol, so the only remaining Travis errors are fine and described above. |
http://www.ti.com/lit/ds/symlink/tpa3251.pdf
Pins 9 and 10 were a little hard to figure out their type, but based on page 23 I chose Input.
I've generated a scripted footprint, but haven't submitted it yet pending the resolution of KiCad/kicad-footprints#955.
![image](https://user-images.githubusercontent.com/1936989/61669785-31acf080-ac96-11e9-9d1e-b8ed84e53ad9.png)
All contributions to the kicad library must follow the KiCad library convention
Thanks for creating a pull request to contribute to the KiCad libraries! To speed up integration of your PR, please check the following items: