Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Warn if using GL_EXT_nontemporal_keyword with GLSL memory model #3874

Merged
merged 1 commit into from
Feb 12, 2025
Merged

Warn if using GL_EXT_nontemporal_keyword with GLSL memory model #3874

merged 1 commit into from
Feb 12, 2025

Conversation

HildarTheDorf
Copy link
Contributor

No description provided.

@HildarTheDorf
Copy link
Contributor Author

Currently the SPIR-V output ignores all MemoryOperands/ImageOperands for the GLSL450 memory model.

jeremy-lunarg
jeremy-lunarg reviewed Feb 11, 2025
View reviewed changes
Copy link
Contributor

@jeremy-lunarg jeremy-lunarg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add a test exercising this warning?

@jeremy-lunarg
Copy link
Contributor

If you rebase on main, it should pass the failing CI test.

@HildarTheDorf HildarTheDorf force-pushed the bug/WarnOnNontemporalGLSLMM branch from 937c946 to 4184dd3 Compare February 12, 2025 00:47
@jeremy-lunarg jeremy-lunarg merged commit 00ac565 into KhronosGroup:main Feb 12, 2025
24 checks passed
@HildarTheDorf HildarTheDorf deleted the bug/WarnOnNontemporalGLSLMM branch February 13, 2025 20:18
@JebScape JebScape mentioned this pull request Feb 19, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeremy-lunarg jeremy-lunarg jeremy-lunarg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@HildarTheDorf @jeremy-lunarg