Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GLSL_EXT_nontemporal_keyword #3854

Conversation

HildarTheDorf
Copy link
Contributor

This is an example implementation of KhronosGroup/GLSL#275

@CLAassistant
Copy link

CLAassistant commented Jan 29, 2025

CLA assistant check
All committers have signed the CLA.

Copy link
Contributor

@arcady-lunarg arcady-lunarg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add a unit test exercising this new functionality? In this case, I think you can just add something to Test/spv.memoryQualifier.frag and then regenerate the expected results with gtests/glslangtests --update-mode.

@HildarTheDorf HildarTheDorf force-pushed the features/nontemporal_attribute branch from a72a8c4 to 5ae5c50 Compare February 1, 2025 03:53
@HildarTheDorf HildarTheDorf force-pushed the features/nontemporal_attribute branch from 0773321 to 9bc4263 Compare February 4, 2025 20:52
@JebScape
Copy link

JebScape commented Feb 4, 2025

Looks good. I’d just expand on the tests a bit more to test more of the changes made than just loads.

@HildarTheDorf
Copy link
Contributor Author

More tests added.

Note: There seems to be a problem with the recently added GL_NV_cooperative_vector tests. The output differs on my machine from the golden results that have been checked in.

@jeremy-lunarg
Copy link
Contributor

Could you add a unit test exercising this new functionality? In this case, I think you can just add something to Test/spv.memoryQualifier.frag and then regenerate the expected results with gtests/glslangtests --update-mode.

@arcady-lunarg can you mark this as resolved?

@jeremy-lunarg
Copy link
Contributor

More tests added.

Note: There seems to be a problem with the recently added GL_NV_cooperative_vector tests. The output differs on my machine from the golden results that have been checked in.

I'm not seeing that at top of main.

@HildarTheDorf
Copy link
Contributor Author

Looks like the CI passes the tests, so I assume the test failures are something about my local machine.
The diff is here: main...umbral-software:glslang:bug/coopvec_test_fails

@jeremy-lunarg jeremy-lunarg merged commit 2b7f94a into KhronosGroup:main Feb 6, 2025
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants