-
Notifications
You must be signed in to change notification settings - Fork 864
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add GLSL_EXT_nontemporal_keyword #3854
Add GLSL_EXT_nontemporal_keyword #3854
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you add a unit test exercising this new functionality? In this case, I think you can just add something to Test/spv.memoryQualifier.frag
and then regenerate the expected results with gtests/glslangtests --update-mode
.
a72a8c4
to
5ae5c50
Compare
0773321
to
9bc4263
Compare
Looks good. I’d just expand on the tests a bit more to test more of the changes made than just loads. |
More tests added. Note: There seems to be a problem with the recently added GL_NV_cooperative_vector tests. The output differs on my machine from the golden results that have been checked in. |
@arcady-lunarg can you mark this as resolved? |
I'm not seeing that at top of main. |
Looks like the CI passes the tests, so I assume the test failures are something about my local machine. |
This is an example implementation of KhronosGroup/GLSL#275