-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade wetzel to handle 2020-12 schemas, delete draft4 schemas. #2034
Conversation
Diffing the HTML artifacts from
Which are replaced on this branch by:
This is expected, and I believe this was one motivation for using the newer draft in the first place. In other news, I tested 2020-12 on a branch of the VSCode plugin, and it seems to perform fine there too. |
Before deleting the old schemas, we should check if other Khronos tools (e.g., glTF-CSharp-Loader) still use them. |
@bghgary Is it possible to upgrade the CSharp loader? Here's an exhaustive list of schema changes:
That's all that changed. The diffs are actually visible as part of this PR, since I'm replacing draft-4 here with the latest version from @lexaknyazev. |
It's possible for sure, but I don't have the bandwidth to do it any time soon. |
OK. Should that hold up this PR? |
I'm not sure. I suppose people can checkout a commit before this PR is merged. Can we tag it somehow maybe? |
No need for a tag. I updated the C# loader. KhronosGroup/glTF-CSharp-Loader#37 |
Yes, thanks to @bghgary who reviewed, tweaked, and merged them. |
Is there a plan to upgrade the Khronos extension schemas to 2020-12? I noticed they are still using draft-04. |
This is actually tracked in #2049 , but ... with little activity, and ... no volunteers yet 😬 |
For consideration by @lexaknyazev and others.
This consolidates us back to a single set of schemas, dropping draft 4 and moving draft 2020-12 into their place. A new version of wetzel handles the two main changes: exclusive min/max, and consts instead of enums.
Once CI runs, I plan to diff the output.