-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updates to KHR_technique_webgl extension spec #1296
Changes from 2 commits
14704c2
4d8cd97
8380e4d
7877f19
17c9237
0049829
6d1488b
9ed17d6
7abef69
5d8b896
593b5a2
7722d59
729e831
8a820db
46503ef
3dc6b26
eecfda0
afcea5d
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Large diffs are not rendered by default.
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,6 +1,6 @@ | ||
{ | ||
"$schema" : "http://json-schema.org/draft-04/schema", | ||
"title" : "KHR_technique_webgl glTF extension", | ||
"title" : "KHR_techniques_webgl glTF extension", | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Add a top-level description. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Add There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Side note: should all the new schemas inherit from |
||
"type" : "object", | ||
"properties" : { | ||
"shaders" : { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I think |
||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -25,6 +25,17 @@ | |
"description" : "The index of the vertex shader." | ||
}, | ||
"name" : {}, | ||
"glExtensions" : { | ||
"type" : "array", | ||
"description" : "Names of WebGL 1.0 extensions to enable.", | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Maybe a better description is |
||
"items" : { | ||
"type" : "string", | ||
"minLength" : 1, | ||
"maxLength" : 256 | ||
}, | ||
"default" : [], | ||
"gltf_webgl" : "`getExtension()`" | ||
}, | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Instead of defaulting to an empty array require that |
||
"extensions" : {}, | ||
"extras" : {} | ||
}, | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -2,7 +2,7 @@ | |
"$schema" : "http://json-schema.org/draft-04/schema", | ||
"title" : "shader", | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Like the main spec, capitalize all the titles. |
||
"type" : "object", | ||
"description" : "A vertex or fragment shader.", | ||
"description" : "A vertex or fragment shader. Exactly one of `uri` or `bufferView` must be provided.", | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Add |
||
"allOf" : [ { "$ref" : "glTFChildOfRootProperty.schema.json" } ], | ||
"properties" : { | ||
"uri" : { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Below - for |
||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,6 +1,25 @@ | ||
{ | ||
"$schema" : "http://json-schema.org/draft-04/schema", | ||
"title" : "attribute", | ||
"allOf" : [ { "$ref" : "glTFid.schema.json" } ], | ||
"description" : "A dictionary object of strings that maps GLSL attribute names to technique parameter IDs." | ||
"type" : "object", | ||
"description" : "An attribute input to a technique, and an optional semantic.", | ||
"allOf" : [ { "$ref" : "glTFProperty.schema.json" } ], | ||
"properties" : { | ||
"type" : { | ||
"type" : "integer", | ||
"description" : "The datatype.", | ||
"enum" : [5120, 5121, 5122, 5123, 5124, 5125, 5126, 35664, 35665, 35666, 35667, 35668, 35669, 35670, 35671, 35672, 35673, 35674, 35675, 35676, 35678], | ||
"gltf_enumNames" : ["BYTE", "UNSIGNED_BYTE", "SHORT", "UNSIGNED_SHORT", "INT", "UNSIGNED_INT", "FLOAT", "FLOAT_VEC2", "FLOAT_VEC3", "FLOAT_VEC4", "INT_VEC2", "INT_VEC3", "INT_VEC4", "BOOL", "BOOL_VEC2", "BOOL_VEC3", "BOOL_VEC4", "FLOAT_MAT2", "FLOAT_MAT3", "FLOAT_MAT4", "SAMPLER_2D"], | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Remove |
||
"gltf_detailedDescription" : "The datatype. All valid values correspond to WebGL enums." | ||
}, | ||
"semantic" : { | ||
"type" : "string", | ||
"description" : "Identifies a parameter with a well-known meaning.", | ||
"gltf_detailedDescription" : "Identifies a parameter with a well-known meaning. Attribute semantics include `\"POSITION\"`, `\"NORMAL\"`, `\"TEXCOORD\"`, `\"COLOR\"`, `\"JOINT\"`, and `\"WEIGHT\"`. `\"TEXCOORD\"` and `\"COLOR\"` attribute semantic property names must be of the form `[semantic]_[set_index]`, e.g., `\"TEXCOORD_0\"`, `\"TEXCOORD_1\"`, `\"COLOR_1\"`, etc. For forward-compatibility, application-specific semantics must start with an underscore, e.g., \"_SIMULATION_TIME\"." | ||
}, | ||
"extensions" : {}, | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
|
||
"extras" : {} | ||
}, | ||
"additionalProperties" : false, | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I don't see this used in other glTF schema files, so remove throughout. |
||
"required" : ["type", "semantic"] | ||
} |
This file was deleted.
This file was deleted.
This file was deleted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There should also be a schema for
material.KHR_technique_webgl.schema.json
.