Lights extension #92
Merged
Lights extension #92
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 29 commits
November 12, 2018 12:06
…s uniform and applied that to UniformLight
ghost
self-requested a review
ghost
suggested changes
Nov 13, 2018
There was a problem hiding this comment.
Looks good to me, just the issue with the default value for the range. I haven't tested it yet, but I think it will happen if range isn't set in the properties for the spot light. We might want to find some example gltf scenes to try it out (if there are any). Or craft our own tests and submit it to e.g. glTF-Sample-Models.
added 2 commits
November 14, 2018 09:27
|
@UX3D-jansson should be all good now |
ghost
self-assigned this
ghost
approved these changes
Nov 14, 2018
|
Feel free to merge when you feel ready! |
…F-WebGL-PBR into feature/LightsExtension
emackey
pushed a commit
that referenced
this pull request
Mar 3, 2021
made tab content scrollable (GSVN-210)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements the KHR_lights_punctual extension.