-
Notifications
You must be signed in to change notification settings - Fork 242
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make text unselectable #61
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution @but0n!
style.css
Outdated
@@ -5,6 +5,7 @@ html, body { | |||
height: 100%; | |||
background: #222; | |||
overflow: hidden; | |||
user-select: none; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm a little nervous about applying this style to the entire body. Is there nowhere a user might want to select any text? There are some color pickers on the GUI, one could imagine a desire to copy-and-paste color values there. Can we be more selective with how this style is applied?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You are right.
Actually user-select
won't influence input elements, which means user still can select, copy-and-paste values in color picker of control panel, only labels is unselectable, which means the color picker of bottom right is not selectable anymore, that would be a problem.
Seems like we got two choices:
- Add
user-select: text
to.pixelPicker
- Move
user-select: none
frombody
to#pbrMath, #inpututs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Whichever seems best, just not on the body/html. Thanks!
- Enable user-select on the body - Disable user-select on #pbrMath, #inputs and .dg (Control pannel)
@@ -33,13 +33,18 @@ html, body { | |||
text-align: center; | |||
} | |||
|
|||
#pbrMath, #inputs, .dg { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is .dg
? I don't see it anywhere else.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
update submodule by new master content
a little bit enhancement