Update readme to show proper texture channels and diffuse color equation #59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@snagy can you review this? Thanks. |
|
cc @speedym |
snagy
approved these changes
Nov 16, 2017
|
Looks good, thanks! |
emackey
pushed a commit
that referenced
this pull request
Mar 3, 2021
ui now no longer overlays the renderer canvas
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The readme was showing incorrect mappings of which channels metallic and roughness pull from. The shader is correct, but I want to minimize confusion.
The equation for diffuse coloring is also incorrect in the readme, as it should be multiplying light*color, not adding.