Scene refactor #37
Merged
Scene refactor #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # scene.js
abwood
reviewed
Jul 13, 2017
mesh.js
Outdated
| return image; | ||
| } | ||
|
|
||
| function loadImages(imageInfos, gl, mesh) { |
There was a problem hiding this comment.
This should probably be moved into the Mesh class, along with loadImage
abwood
reviewed
Jul 13, 2017
mesh.js
Outdated
| } | ||
| } | ||
|
|
||
| function applyState(gl, program, globalState, localState) { |
There was a problem hiding this comment.
Unless we want to add a context.js (not suggesting this), I'd just move applyState and disableState into the Mesh class too.
|
Looks really good to me! |
|
@abwood's comments have been addressed. |
snagy
approved these changes
Jul 17, 2017
|
Looks good to me. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a fairly large set of changes, but offers a number of key improvements.
SceneandMeshboth sharedscene.js.Meshwas the larger class by far, and has been split off into its ownmesh.jsfile.There's still work to do. This could be part of this PR or could be made as later PRs after this is merged.
CLAMP_TO_EDGEandMIRROR_REPEATare not yet supported.mesh.jsare still global in scope and could be better belonging to either Mesh or Scene./cc @moneimne @snagy @abwood
(Note: Shader/GLSL code is un-touched here, only JavaScript changes.)