Add "Damaged Helmet" model. #35
Conversation
main.js
Outdated
| @@ -229,7 +229,7 @@ function init(vertSource, fragSource) { | |||
|
|
|||
|
|
|||
| var text = { Model: "BoomBox" }; | |||
There was a problem hiding this comment.
What do you think about making this model the default one upon opening the demo? I think it displays more of a variety of materials than the BoomBox model (mirroring glass, brushed metal sides, smoother metal on back, metallic/rough scratches with interesting highlights, and diffuse tubing underneath).
|
Looks like there are still a few issues with the model- Tangent4 and a bytestride of 0. |
|
Yeah, I'm sure it's from an older exporter. Actually when we first got it, the metalness map was in the red channel and had to be moved. I don't have the original, but I suppose some minor manual cleanup should be possible. I wonder if anyone has a working glTF 2.0 importer/converter yet? |
|
Although I haven't tested it yet: Using a large, complex model as the default is questionable, IMHO. People (like me) with a slow connection might see a blank screen for several minutes. (Although, they won't: After one minute, they'll close the window). I think that a very simple model (maybe the spheres or some cube) would be preferable here, at least as long as there is not progress indicator. But maybe that's just me... |
@javagl I agree we need loading/progress indicators and good performance. But this new model is only 3.5 megs in size, to the BoomBox's 10 megs size. So switching is a performance win here.
@sbtron I've managed to fix some problems. I actually imported the model with @ksons blender importer, hooked up the existing textures and then re-exported it with the new Khronos Blender exporter. Worked really well. This should be ready to merge now. |
|
@lexaknyazev The newly re-exported DamagedHelmet should be good to go. When time permits I'll create a few variants of it (binary, embedded) and open a PR back to sample models. I don't know the status of the other models. They may be in need of similar import/export treatment to bring them up to date. The WaterBottle in particular is used in a number of glTF slide presentations, but not available in the sample repo. |
The AppleTree, FarmLandDiorama, Telephone, and WaterBottle are in my backlog. The first three have issues which is why they haven't made it in yet. I have a version of the WaterBottle ready, but haven't had time to submit it yet. |
|
@moneimne if you're happy can you merge this? Thanks! |
|
Thanks, @emackey! |
/cc @moneimne