Add attribution for the shader equations, also some misc cleanup #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rename the "normal matrix" to better reflect its usage as a transform from model -> world Don't modify the gl context, instead store information about extensions in the state move the camera/view calculations outside of the per-mesh loop Add information about which papers the different lighting information came from to the shader.
|
Thanks @snagy! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rename the "normal matrix" to better reflect its usage as a transform from model -> world
Don't modify the gl context, instead store information about extensions in the state
move the camera/view calculations outside of the per-mesh loop
Add information about which papers the different lighting information came from to the shader.