Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Metallic and Roughness parameters instantly deleted #11

Closed
moneimne opened this issue Jun 7, 2017 · 2 comments
Closed

Metallic and Roughness parameters instantly deleted #11

moneimne opened this issue Jun 7, 2017 · 2 comments
Labels
bug

Comments

@moneimne
Copy link
Contributor

moneimne commented Jun 7, 2017

When I run the live demo from the main repository, the metallic and roughness parameters are always 0. I think that this issue may have come from the most recent pull request. By moving the initialization of the u_MetallicRoughnessValues uniform up, the values are deleted right after in following checks.
@moneimne moneimne mentioned this issue Jun 7, 2017
Merged
@moneimne moneimne added the bug label Jun 7, 2017
@emackey
Copy link
Member

emackey commented Jun 7, 2017

Good catch, thanks @moneimne.

/cc @abwood

abwood added a commit to abwood/glTF-Sample-Viewer that referenced this issue Jun 7, 2017
@abwood
Fixed bug where metallic-roughness uniforms were immediately deleted …
b8128dd 
…if metallic-roughness texture was present. Fixes KhronosGroup#11
@abwood abwood mentioned this issue Jun 7, 2017
Merged
@abwood
Copy link
Contributor

abwood commented Jun 7, 2017

Yikes, good catch.

emackey pushed a commit that referenced this issue Mar 3, 2021
@UX3D-labode
Merge pull request #11 from ux3d/fix/punctual_light_brightness
14e9682 
Fix/punctual light brightness
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@emackey @abwood @moneimne