TypeError: gl.hasSRGBExt is null

[javagl]

This appears in the live demo, on FireFox 52.1.2, Windows (32bit), GeForce 8800 GT.

Most likely an issue of outdated drivers or so (this is not my "real" PC), but maybe it can or should somehow be handled, I'm not sure how common this extension is.

Stack trace:

TypeError: gl.hasSRGBExt is null[Learn More]  scene.js:230:92
    initTextures http://github.khronos.org/glTF-WebGL-PBR/scene.js:230:92
    Mesh http://github.khronos.org/glTF-WebGL-PBR/scene.js:49:30
    Scene http://github.khronos.org/glTF-WebGL-PBR/scene.js:323:30
    updateModel/<.success http://github.khronos.org/glTF-WebGL-PBR/main.js:86:25
    jQuery.Callbacks/fire http://github.khronos.org/glTF-WebGL-PBR/jquery-3.1.1.js:3305:11
    jQuery.Callbacks/self.fireWith http://github.khronos.org/glTF-WebGL-PBR/jquery-3.1.1.js:3435:7

[emackey]

Thanks for writing this up. I've reproduced this on two other copies of Firefox (one on Windows 10, one on Windows 7, with updated-this-year drivers). Also, this appears to affect Edge as well.

/cc @snagy any thoughts here? Can we treat the sRGB extension as optional? Or can we look for WebGL 2 support with sRGB in core, which seems to enjoy wider browser support than the sRGB extension for WebGL 1?

[javagl]

Just for reference: This seems to be the same as #3 (where @cx20 explicitly listed the cases where this error happens)

[emackey]

I merged a workaround in #6 that falls back on gl.RGBA when sRGB_EXT is not present. This allows the project to load on Firefox and Edge.

I'm still looking for feedback on whether this is the "right" thing to do, or if there is a better way.

[javagl]

Works on my "real" PC. I'll test it with the old one ASA I have the chance, but until then, assume that the issue is fixed now. (Sorry, no other (technical) feedback from me for this point - I'm not familiar with the details of GL texture handling, color spaces, HDR etc...)

[snagy]

@emackey I think your solution is the right way to handle it. This was my oversight in the previous revision. Thanks for the fix!

[emackey]

Thanks @snagy!