Merge pull request #447 from KhronosGroup/fix/filter_transmissive_geo…

…metry Filter drawables behind camera each frame
KhronosGroup · Dec 16, 2022 · 98fc22c · 98fc22c
2 parents 017988f + 8c125d7
commit 98fc22c
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/source/Renderer/renderer.js b/source/Renderer/renderer.js
@@ -331,15 +331,16 @@ class gltfRenderer
 
         // filter materials with transmission extension
         this.transmissionDrawables = currentCamera.sortPrimitivesByDepth(state.gltf, this.transmissionDrawables);
-        for (const drawable of this.transmissionDrawables)
+        for (const drawable of this.transmissionDrawables.filter((a) => a.depth <= 0))
         {
             let renderpassConfiguration = {};
             renderpassConfiguration.linearOutput = false;
             this.drawPrimitive(state, renderpassConfiguration, drawable.primitive, drawable.node, this.viewProjectionMatrix, this.opaqueRenderTexture);
         }
 
+
         this.transparentDrawables = currentCamera.sortPrimitivesByDepth(state.gltf, this.transparentDrawables);
-        for (const drawable of this.transparentDrawables)
+        for (const drawable of this.transparentDrawables.filter((a) => a.depth <= 0))
         {
             let renderpassConfiguration = {};
             renderpassConfiguration.linearOutput = false;

diff --git a/source/gltf/camera.js b/source/gltf/camera.js
@@ -88,7 +88,6 @@ class gltfCamera extends GltfObject
         // 2. Sort primitives so that the furthest nodes are rendered first.
         //    This is required for correct transparency rendering.
         return drawables
-            .filter((a) => a.depth <= 0)
             .sort((a, b) => a.depth - b.depth);
     }