Merge pull request #429 from KhronosGroup/fix/robustness_missing_ibm

Accept missing inverse bind matrices
KhronosGroup · Nov 4, 2022 · 0cd6901 · 0cd6901
2 parents 75d834d + 909fd24
commit 0cd6901
Showing 1 changed file with 12 additions and 5 deletions.
diff --git a/source/gltf/skin.js b/source/gltf/skin.js
@@ -68,7 +68,11 @@ class gltfSkin extends GltfObject
 
     computeJoints(gltf, parentNode, webGlContext)
     {
-        const ibmAccessor = gltf.accessors[this.inverseBindMatrices].getDeinterlacedView(gltf);
+        let ibmAccessor = null;
+        if (this.inverseBindMatrices !== undefined) {
+            ibmAccessor = gltf.accessors[this.inverseBindMatrices].getDeinterlacedView(gltf);
+        }
+
         this.jointMatrices = [];
         this.jointNormalMatrices = [];
 
@@ -80,10 +84,13 @@ class gltfSkin extends GltfObject
         {
             const node = gltf.nodes[joint];
 
-            let jointMatrix = mat4.create();
-            let ibm = jsToGlSlice(ibmAccessor, i * 16, 16);
-            mat4.mul(jointMatrix, node.worldTransform, ibm);
-            mat4.mul(jointMatrix, parentNode.inverseWorldTransform, jointMatrix);
+            let jointMatrix = mat4.clone(node.worldTransform);
+
+            if (ibmAccessor !== null) {
+                let ibm = jsToGlSlice(ibmAccessor, i * 16, 16);
+                mat4.mul(jointMatrix, jointMatrix, ibm);
+                mat4.mul(jointMatrix, parentNode.inverseWorldTransform, jointMatrix);
+            }
 
             let normalMatrix = mat4.create();
             mat4.invert(normalMatrix, jointMatrix);