Merge pull request #408 from KhronosGroup/fix/recursive_light_instant…

…iation

Gather all lights recursively in `getVisibleLights()`

source/Renderer/renderer.js

@@ -279,7 +279,7 @@ class gltfRenderer
         this.viewMatrix = currentCamera.getViewMatrix(state.gltf);
         this.currentCameraPosition = currentCamera.getPosition(state.gltf);
 
-        this.visibleLights = this.getVisibleLights(state.gltf, scene);
+        this.visibleLights = this.getVisibleLights(state.gltf, scene.nodes);
         if (this.visibleLights.length === 0 && !state.renderingParameters.useIBL &&
             state.renderingParameters.useDirectionalLightsWithDisabledIBL)
         {
@@ -586,18 +586,25 @@ class gltfRenderer
     }
 
     /// Compute a list of lights instantiated by one or more nodes as a list of node-light tuples.
-    getVisibleLights(gltf, scene)
+    getVisibleLights(gltf, nodes)
     {
-        const nodeLights = [];
-        for (const nodeIndex of scene.nodes) {
+        let nodeLights = [];
+
+        for (const nodeIndex of nodes) {
             const node = gltf.nodes[nodeIndex];
+
+            if (node.children !== undefined) {
+                nodeLights = nodeLights.concat(this.getVisibleLights(gltf, node.children))
+            }
+
             const lightIndex = node.extensions?.KHR_lights_punctual?.light;
             if (lightIndex === undefined) {
                 continue;
             }
             const light = gltf.lights[lightIndex];
             nodeLights.push([node, light]);
         }
+
         return nodeLights;
     }