Skip to content
This repository has been archived by the owner on Dec 22, 2023. It is now read-only.

Rounded Cube sample for KHR_xmp_json_ld extension. #291

Merged
merged 1 commit into from
Dec 3, 2023

Conversation

weegeekps
Copy link

This adds the Rounded Cube sample to the samples repository for the upcoming KHR_xmp_json_ld extension.

@weegeekps weegeekps mentioned this pull request Jan 29, 2021
5 tasks
@cx20
Copy link
Contributor

cx20 commented Jan 29, 2021

To be consistent with other samples, it is better to name the sample model file the same as the folder name is a good idea.

Folder Name File Name
Duck/glTF Duck.gltf
Duck/glTF-Binary Duck.glb

Also, to keep things simple, I think it would be better to put the .bin file that this model refers to in the same folder.
This is because some viewers This is because some viewers cannot display correctly when using a relative path.
For example, the Khronos glTF Sample Viewer fails to display the .bin file if it is in a different folder.

@DRx3D DRx3D merged commit 300e3c8 into KhronosGroup:master Dec 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants