Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add webgl2 tests to conformance/misc/shader-precision-format.html. #3717

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add webgl2 tests to conformance/misc/shader-precision-format.html. #3717

wants to merge 1 commit into from

Conversation

kdashg
Copy link
Contributor

@kdashg kdashg commented Feb 20, 2025

Passes in Mac Safari, fails in Mac Firefox.

kenrussell
kenrussell approved these changes Feb 21, 2025
View reviewed changes
Copy link
Member

@kenrussell kenrussell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd prefer to put the WebGL 2 specific parts in a new conformance2/misc/shader-precision-format.html to make it clearer that the test changes behavior under WebGL 2, but as you see fit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kenrussell kenrussell kenrussell approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kdashg @kenrussell