Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: Add Swapchain wrapper #8648

Merged

Conversation

artem-lunarg
Copy link
Contributor

Adds vkt::Swapchain

@ci-tester-lunarg
Copy link
Collaborator

CI Vulkan-ValidationLayers build queued with queue ID 270732.

Swapchain(Swapchain &&rhs) noexcept : NonDispHandle(std::move(rhs)) {}
Swapchain &operator=(Swapchain &&) = default;
~Swapchain() noexcept;
void destroy() noexcept;
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

still old name convention because existing macros for non-dispatchable handles use it

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ya, destory andinit and handle are the final bosses for naming, but figured that is for when things get boring around here lol

@ci-tester-lunarg
Copy link
Collaborator

CI Vulkan-ValidationLayers build # 17672 running.

@ci-tester-lunarg
Copy link
Collaborator

CI Vulkan-ValidationLayers build # 17672 failed.

@ci-tester-lunarg
Copy link
Collaborator

CI Vulkan-ValidationLayers build queued with queue ID 270759.

@ci-tester-lunarg
Copy link
Collaborator

CI Vulkan-ValidationLayers build # 17673 running.

@ci-tester-lunarg
Copy link
Collaborator

CI Vulkan-ValidationLayers build # 17673 passed.

@ci-tester-lunarg
Copy link
Collaborator

CI Vulkan-ValidationLayers build queued with queue ID 270780.

@ci-tester-lunarg
Copy link
Collaborator

CI Vulkan-ValidationLayers build # 17674 running.

std::optional<uint32_t> Device::ComputeOnlyQueueFamily() const {
return QueueFamily(VK_QUEUE_COMPUTE_BIT, VK_QUEUE_GRAPHICS_BIT);
}
std::optional<uint32_t> Device::ComputeOnlyQueueFamily() const { return QueueFamily(VK_QUEUE_COMPUTE_BIT, VK_QUEUE_GRAPHICS_BIT); }
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

decided to format entire file

@artem-lunarg artem-lunarg marked this pull request as ready for review October 3, 2024 23:45
@artem-lunarg artem-lunarg requested a review from a team as a code owner October 3, 2024 23:45
@ci-tester-lunarg
Copy link
Collaborator

CI Vulkan-ValidationLayers build # 17674 passed.

@artem-lunarg artem-lunarg merged commit a17bc71 into KhronosGroup:main Oct 4, 2024
21 checks passed
@artem-lunarg artem-lunarg deleted the artem-swapchain-wrapper branch October 4, 2024 05:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants