-
Notifications
You must be signed in to change notification settings - Fork 403
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tests: Add Swapchain wrapper #8648
tests: Add Swapchain wrapper #8648
Conversation
CI Vulkan-ValidationLayers build queued with queue ID 270732. |
Swapchain(Swapchain &&rhs) noexcept : NonDispHandle(std::move(rhs)) {} | ||
Swapchain &operator=(Swapchain &&) = default; | ||
~Swapchain() noexcept; | ||
void destroy() noexcept; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
still old name convention because existing macros for non-dispatchable handles use it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ya, destory
andinit
and handle
are the final bosses for naming, but figured that is for when things get boring around here lol
CI Vulkan-ValidationLayers build # 17672 running. |
CI Vulkan-ValidationLayers build # 17672 failed. |
176650c
to
14030bb
Compare
CI Vulkan-ValidationLayers build queued with queue ID 270759. |
CI Vulkan-ValidationLayers build # 17673 running. |
CI Vulkan-ValidationLayers build # 17673 passed. |
14030bb
to
f967268
Compare
CI Vulkan-ValidationLayers build queued with queue ID 270780. |
CI Vulkan-ValidationLayers build # 17674 running. |
std::optional<uint32_t> Device::ComputeOnlyQueueFamily() const { | ||
return QueueFamily(VK_QUEUE_COMPUTE_BIT, VK_QUEUE_GRAPHICS_BIT); | ||
} | ||
std::optional<uint32_t> Device::ComputeOnlyQueueFamily() const { return QueueFamily(VK_QUEUE_COMPUTE_BIT, VK_QUEUE_GRAPHICS_BIT); } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
decided to format entire file
CI Vulkan-ValidationLayers build # 17674 passed. |
Adds
vkt::Swapchain