Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert markdown documentation to asciidoc #765

Merged
merged 20 commits into from
Aug 14, 2023

Conversation

SaschaWillems
Copy link
Collaborator

@SaschaWillems SaschaWillems commented Jul 28, 2023

Description

This PR converts all markdown documentation files of our repo to asciidoc (third_party modules etc. are excluded). There are no changes to the general structure or contents, so this is mostly a 1:1 to change that most users won't notice. The PR does fix a few broken links from master, does some minor markup and formatting fixes and changes some image links to be better suited for the Antora documentation project. There are only slight visual changes due to differences in the github asciidoc renderer.

This conversion is a base for getting the samples into the Vulkan documentation site.

Fixes #693

General Checklist:

Please ensure the following points are checked:

  • My code follows the coding style
  • I have reviewed file licenses
  • I have commented any added functions (in line with Doxygen)
  • I have commented any code that could be hard to understand
  • My changes do not add any new compiler warnings
  • My changes do not add any new validation layer errors or warnings
  • I have used existing framework/helper functions where possible
  • My changes do not add any regressions
  • I have tested every sample to ensure everything runs correctly
  • This PR describes the scope and expected impact of the changes I am making

Note: The Samples CI runs a number of checks including:

  • I have updated the header Copyright to reflect the current year (CI build will fail if Copyright is out of date)
  • My changes build on Windows, Linux, macOS and Android. Otherwise I have documented any exceptions

@SaschaWillems
Copy link
Collaborator Author

Note: This will break with copyright checks, as a lot of files have changed. I don't want to change copyright in all these files, so if we decide to merge we should just ignore failing copyright checks.

JoseEmilio-ARM
JoseEmilio-ARM previously approved these changes Jul 31, 2023
gpx1000
gpx1000 previously approved these changes Jul 31, 2023
Copy link
Collaborator

@gpx1000 gpx1000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the work on this Sascha!

tomadamatkinson
tomadamatkinson previously approved these changes Aug 1, 2023
Copy link
Collaborator

@tomadamatkinson tomadamatkinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for pushing the documentation goal forward 🔥

asuessenbach
asuessenbach previously approved these changes Aug 2, 2023
A sample must consistently apply a single code style.

A `.clang-format` file is included with this repository, please use `clang-format -style=file` to verify the code style.
Ensure that you are using clang-format 8.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is clang-format 8 still the correct version?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure. This is just a conversion (and some minor fixes) of the current documentation. If this is outdated it would be best to fix it with the current markdown and I'll merge that change.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

15 is the correct version. We should do a documentation pass separate to this PR

This doesn't change anything in how the readmes are displayed in github, but it makes antora documentation generation easier
This doesn't change anything in how the readmes are displayed in github, but it makes antora documentation generation easier
This doesn't change anything in how the readmes are displayed in github, but it makes antora documentation generation easier
This doesn't change anything in how the readmes are displayed in github, but it makes antora documentation generation easier
This doesn't change anything in how the readmes are displayed in github, but it makes antora documentation generation easier
asuessenbach
asuessenbach previously approved these changes Aug 3, 2023
@marty-johnson59 marty-johnson59 merged commit c23ffb7 into KhronosGroup:main Aug 14, 2023
@SaschaWillems SaschaWillems deleted the asciidoc_conversion branch December 18, 2024 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Convert all documentation to AsciiDoc
6 participants