-
Notifications
You must be signed in to change notification settings - Fork 666
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Convert markdown documentation to asciidoc #765
Convert markdown documentation to asciidoc #765
Conversation
Note: This will break with copyright checks, as a lot of files have changed. I don't want to change copyright in all these files, so if we decide to merge we should just ignore failing copyright checks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the work on this Sascha!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks for pushing the documentation goal forward 🔥
A sample must consistently apply a single code style. | ||
|
||
A `.clang-format` file is included with this repository, please use `clang-format -style=file` to verify the code style. | ||
Ensure that you are using clang-format 8. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is clang-format 8 still the correct version?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure. This is just a conversion (and some minor fixes) of the current documentation. If this is outdated it would be best to fix it with the current markdown and I'll merge that change.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
15 is the correct version. We should do a documentation pass separate to this PR
This doesn't change anything in how the readmes are displayed in github, but it makes antora documentation generation easier
6da06f6
This doesn't change anything in how the readmes are displayed in github, but it makes antora documentation generation easier
This doesn't change anything in how the readmes are displayed in github, but it makes antora documentation generation easier
This doesn't change anything in how the readmes are displayed in github, but it makes antora documentation generation easier
This doesn't change anything in how the readmes are displayed in github, but it makes antora documentation generation easier
Description
This PR converts all markdown documentation files of our repo to asciidoc (third_party modules etc. are excluded). There are no changes to the general structure or contents, so this is mostly a 1:1 to change that most users won't notice. The PR does fix a few broken links from master, does some minor markup and formatting fixes and changes some image links to be better suited for the Antora documentation project. There are only slight visual changes due to differences in the github asciidoc renderer.
This conversion is a base for getting the samples into the Vulkan documentation site.
Fixes #693
General Checklist:
Please ensure the following points are checked:
Note: The Samples CI runs a number of checks including: