Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sample for separate image samplers #355

Merged
merged 21 commits into from
Oct 13, 2021
Merged

Add sample for separate image samplers #355

merged 21 commits into from
Oct 13, 2021

Conversation

SaschaWillems
Copy link
Collaborator

Description

This PR adds a basic api sample demonstrating how to separate images and samplers. This is similar to the LunarG sample from the archived repository.

The sample uses one image and two different samplers, one with linear and one with nearest filtering, which can be selected at runtime.

It also comes with a small tutorial/readme describing the relevant parts of the application and shader code and a small comparison with a combined setup.

The sample was tested on Windows 10 with an NVIDIA RTX 2060. It's based on the texture loading sample, so it should work any pretty much every platform.

Fixes #302

General Checklist:

Please ensure the following points are checked:

  • My code follows the coding style
  • I have reviewed file licenses
  • I have updated the header Copyright to reflect the current year (CI build will fail if Copyright is out of date)
  • I have commented any added functions (in line with Doxygen)
  • I have commented any code that could be hard to understand
  • My changes do not add any new compiler warnings
  • My changes do not add any new validation layer errors or warnings
  • I have used existing framework/helper functions where possible
  • My changes build on Windows, Linux, macOS and Android. Otherwise I have documented any exceptions
  • My changes do not add any regressions
  • I have tested every sample to ensure everything runs correctly
  • This PR describes the scope and expected impact of the changes I am making

Sample Checklist

If your PR contains a new or modified sample, these further checks must be carried out in addition to the General Checklist:

  • I have tested the sample on at least one compliant Vulkan implementation
  • If the sample is vendor-specific, I have tagged it appropriately
  • I have stated on what implementation the sample has been tested so that others can test on different implementations and platforms
  • Any dependent assets have been merged and published in downstream modules
  • For new samples, I have added a paragraph with a summary to the appropriate chapter in the samples readme

gpx1000
gpx1000 previously approved these changes Sep 27, 2021
Copy link
Collaborator

@gpx1000 gpx1000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small warning issues but otherwise looks good to me runs well here.

- Initialize member variables
- Remove explicit buffer reset
- Mark destructor as override
gary-sweet
gary-sweet previously approved these changes Oct 5, 2021
Copy link
Contributor

@gary-sweet gary-sweet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@marty-johnson59 marty-johnson59 merged commit af29ca1 into KhronosGroup:master Oct 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sample request: Inclusion of the LunarG sample on separate sampled images and samplers and how to use them
5 participants