-
Notifications
You must be signed in to change notification settings - Fork 683
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add sample for separate image samplers #355
Merged
marty-johnson59
merged 21 commits into
KhronosGroup:master
from
SaschaWillems:separate_image_sampler
Oct 13, 2021
Merged
Add sample for separate image samplers #355
marty-johnson59
merged 21 commits into
KhronosGroup:master
from
SaschaWillems:separate_image_sampler
Oct 13, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gpx1000
previously approved these changes
Sep 27, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
small warning issues but otherwise looks good to me runs well here.
- Initialize member variables - Remove explicit buffer reset - Mark destructor as override
gary-sweet
previously approved these changes
Oct 5, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me
JoseEmilio-ARM
approved these changes
Oct 11, 2021
gpx1000
approved these changes
Oct 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a basic api sample demonstrating how to separate images and samplers. This is similar to the LunarG sample from the archived repository.
The sample uses one image and two different samplers, one with linear and one with nearest filtering, which can be selected at runtime.
It also comes with a small tutorial/readme describing the relevant parts of the application and shader code and a small comparison with a combined setup.
The sample was tested on Windows 10 with an NVIDIA RTX 2060. It's based on the texture loading sample, so it should work any pretty much every platform.
Fixes #302
General Checklist:
Please ensure the following points are checked:
Sample Checklist
If your PR contains a new or modified sample, these further checks must be carried out in addition to the General Checklist: