Reference Docker Hub image by SHA #576
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Download the Docker Hub container image by its SHA, so that we know exactly which version of the Asciidoctor tools we use to buid the spec. The version (SHA) should be updated periodically as new container images are published.
Also see if we can reference the image using both its tag and its SHA.
It appears that it is legal to reference the docker image using both its tag and its SHA, but the tag is totally ignored in that case. Since there is no error checking that the tag matches the SHA, it seems better to just use the SHA and rely on a comment to document which tag this corresponds to.
oddhack
reviewed
Jul 2, 2024
Co-authored-by: Jon Leech <4693344+oddhack@users.noreply.github.com>
|
Merging as editorial |
keryell
pushed a commit
that referenced
this pull request
Sep 10, 2024
Reference Docker Hub image by SHA
gmlueck
added a commit
that referenced
this pull request
Nov 7, 2024
Reference Docker Hub image by SHA (cherry picked from commit 3fa9c77)
gmlueck
added a commit
that referenced
this pull request
Nov 7, 2024
Reference Docker Hub image by SHA (cherry picked from commit 3fa9c77)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Download the Docker Hub container image by its SHA, so that we know exactly which version of the Asciidoctor tools we use to build the spec. The version (SHA) should be updated periodically as new container images are published.