Correct commit id when building from CI #573
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gmlueck
force-pushed
the
gmlueck/ci-commit
branch
from
a4cf3a4 to
04f8e33
Compare
The revision line at the top of the spec is supposed to include the git commit ID that the spec was built from. This works fine when building manually, but there has been a longstanding bug preventing this form working when the spec is built in GitHub CI. I think the problem is that the GitHub action doesn't check out any of the git history, so the "git describe" and "git log" commands don't work. Rather than use git commands to get the commit ID, we can just get the ID from the GitHib $GITHUB_SHA variable. I also simplified the information in the revision line, so it just contains the commit ID and not the branch information. I think this is the only critical information because we can always map the ID back to a branch later if we want.
gmlueck
force-pushed
the
gmlueck/ci-commit
branch
from
04f8e33 to
6b8dffa
Compare
gmlueck
changed the title
keryell
pushed a commit
that referenced
this pull request
Sep 10, 2024
Correct commit id when building from CI
gmlueck
added a commit
that referenced
this pull request
Nov 7, 2024
Correct commit id when building from CI (cherry picked from commit 1b4d5b6)
gmlueck
added a commit
that referenced
this pull request
Nov 7, 2024
Correct commit id when building from CI (cherry picked from commit 1b4d5b6)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The revision line at the top of the spec is supposed to include the git commit ID that the spec was built from. This works fine when building manually, but there has been a longstanding bug preventing this form working when the spec is built in GitHub CI.
I think the problem is that the GitHub action doesn't check out any of the git history, so the "git describe" and "git log" commands don't work. Rather than use git commands to get the commit ID, we can just get the ID from the GitHib $GITHUB_SHA variable.
I also simplified the information in the revision line, so it just contains the commit ID and not the branch information. I think this is the only critical information because we can always map the ID back to a branch later if we want.