Reflow: break lines at end of sentence / 80 cols #495
Conversation
There was a problem hiding this comment.
This looks good. I verified the following:
- The generated PDF has no unexpected differences vs. the main branch. (The only differences are the date and commit ID on the title page.)
- The script changes in this PR are identical to those in Run reflow #481, which were already reviewed.
gmlueck
changed the title
gmlueck
changed the title
|
Merging as editorial |
| @@ -0,0 +1,7 @@ | |||
| #!/usr/bin/python3 -i | |||
| # | |||
| # Copyright (c) 2018-2019 Collabora, Ltd. | |||
There was a problem hiding this comment.
Copyright 2023 The Khronos Group Inc.?
There was a problem hiding this comment.
Yeah, that seems weird since the implementation of the Python package is copyright Khronos. I created a new __init__.py file in #558.
There was a problem hiding this comment.
Thanks, and yes copy / pasted from Vulkan (https://github.com/KhronosGroup/Vulkan-Docs/blob/master/scripts/spec_tools/__init__.py)
| @@ -0,0 +1,454 @@ | |||
| #!/usr/bin/python3 -i | |||
| # | |||
| # Copyright 2013-2023 The Khronos Group Inc. | |||
There was a problem hiding this comment.
I assume that @TApplencourt started by copying the "conventions.py" file from the Vulkan repo, which has this copyright date range. Since this file is a derived work, I think it's correct to keep the original date range.
Run Reflow, rebased from master
Run Reflow, rebased from master (cherry picked from commit e859ef7)
Run Reflow, rebased from master (cherry picked from commit e859ef7)
Follow up of #481 Rebase from master ( 463a26c )