Fix bugs in SYCL2020 USM section #485
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkinsner
commented
Oct 31, 2023
mkinsner
commented
- The templated aligned_alloc_host had the wrong return type, not matching the other templated signatures and clear intent of the API
- Zero size malloc behavior was only specified for device allocations, when it needs to be specified for host and shared mallocs as well
- Fix incorrect word use
TApplencourt
approved these changes
Oct 31, 2023
gmlueck
approved these changes
Nov 9, 2023
illuhad
approved these changes
Nov 9, 2023
|
I checked the CTS, and I didn't see any assumption that the return type of |
keryell
pushed a commit
that referenced
this pull request
Sep 10, 2024
Fix bugs in SYCL2020 USM section
gmlueck
added a commit
that referenced
this pull request
Nov 7, 2024
Fix bugs in SYCL2020 USM section (cherry picked from commit e8d6bb6)
gmlueck
added a commit
that referenced
this pull request
Nov 7, 2024
Fix bugs in SYCL2020 USM section (cherry picked from commit e8d6bb6)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.