Fix allowed types for OpConstantNull #2361
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The SPIR-V Specification allows OpConstantNull types to be scalar or vector booleans, integers, or floats. Update an assert for this and add a SPIR-V -> LLVM IR test.
MrSidims
approved these changes
Feb 13, 2024
|
Restarting CI just in case |
svenvh
added a commit
to svenvh/SPIRV-LLVM-Translator
that referenced
this pull request
Feb 15, 2024
) The SPIR-V Specification allows `OpConstantNull` types to be scalar or vector booleans, integers, or floats. Update an assert for this and add a SPIR-V -> LLVM IR test. (cherry picked from commit 9ec969c)
svenvh
added a commit
to svenvh/SPIRV-LLVM-Translator
that referenced
this pull request
Feb 15, 2024
) The SPIR-V Specification allows `OpConstantNull` types to be scalar or vector booleans, integers, or floats. Update an assert for this and add a SPIR-V -> LLVM IR test. (cherry picked from commit 9ec969c)
svenvh
added a commit
to svenvh/SPIRV-LLVM-Translator
that referenced
this pull request
Feb 15, 2024
) The SPIR-V Specification allows `OpConstantNull` types to be scalar or vector booleans, integers, or floats. Update an assert for this and add a SPIR-V -> LLVM IR test. (cherry picked from commit 9ec969c)
svenvh
added a commit
to svenvh/SPIRV-LLVM-Translator
that referenced
this pull request
Feb 15, 2024
) The SPIR-V Specification allows `OpConstantNull` types to be scalar or vector booleans, integers, or floats. Update an assert for this and add a SPIR-V -> LLVM IR test. (cherry picked from commit 9ec969c)
svenvh
added a commit
to svenvh/SPIRV-LLVM-Translator
that referenced
this pull request
Feb 15, 2024
) The SPIR-V Specification allows `OpConstantNull` types to be scalar or vector booleans, integers, or floats. Update an assert for this and add a SPIR-V -> LLVM IR test. (cherry picked from commit 9ec969c)
svenvh
added a commit
to svenvh/SPIRV-LLVM-Translator
that referenced
this pull request
Feb 15, 2024
) The SPIR-V Specification allows `OpConstantNull` types to be scalar or vector booleans, integers, or floats. Update an assert for this and add a SPIR-V -> LLVM IR test. (cherry picked from commit 9ec969c)
svenvh
added a commit
to svenvh/SPIRV-LLVM-Translator
that referenced
this pull request
Feb 15, 2024
) The SPIR-V Specification allows `OpConstantNull` types to be scalar or vector booleans, integers, or floats. Update an assert for this and add a SPIR-V -> LLVM IR test. (cherry picked from commit 9ec969c)
svenvh
added a commit
that referenced
this pull request
Feb 15, 2024
The SPIR-V Specification allows `OpConstantNull` types to be scalar or vector booleans, integers, or floats. Update an assert for this and add a SPIR-V -> LLVM IR test. (cherry picked from commit 9ec969c)
svenvh
added a commit
that referenced
this pull request
Feb 15, 2024
The SPIR-V Specification allows `OpConstantNull` types to be scalar or vector booleans, integers, or floats. Update an assert for this and add a SPIR-V -> LLVM IR test. (cherry picked from commit 9ec969c)
svenvh
added a commit
that referenced
this pull request
Feb 15, 2024
The SPIR-V Specification allows `OpConstantNull` types to be scalar or vector booleans, integers, or floats. Update an assert for this and add a SPIR-V -> LLVM IR test. (cherry picked from commit 9ec969c)
svenvh
added a commit
that referenced
this pull request
Feb 15, 2024
The SPIR-V Specification allows `OpConstantNull` types to be scalar or vector booleans, integers, or floats. Update an assert for this and add a SPIR-V -> LLVM IR test. (cherry picked from commit 9ec969c)
svenvh
added a commit
that referenced
this pull request
Feb 15, 2024
The SPIR-V Specification allows `OpConstantNull` types to be scalar or vector booleans, integers, or floats. Update an assert for this and add a SPIR-V -> LLVM IR test. (cherry picked from commit 9ec969c)
svenvh
added a commit
that referenced
this pull request
Feb 15, 2024
The SPIR-V Specification allows `OpConstantNull` types to be scalar or vector booleans, integers, or floats. Update an assert for this and add a SPIR-V -> LLVM IR test. (cherry picked from commit 9ec969c)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The SPIR-V Specification allows
OpConstantNulltypes to be scalar or vector booleans, integers, or floats. Update an assert for this and add a SPIR-V -> LLVM IR test.