Update LongConstantCompositeINTEL to LongCompositesINTEL capability after Headers change #2258
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vmaksimo
changed the title
MrSidims
requested changes
Dec 8, 2023
| @@ -43,7 +43,7 @@ EXT(SPV_INTEL_variable_length_array) | |||
| EXT(SPV_INTEL_fp_fast_math_mode) | |||
| EXT(SPV_INTEL_fpga_cluster_attributes) | |||
| EXT(SPV_INTEL_loop_fuse) | |||
| EXT(SPV_INTEL_long_constant_composite) | |||
There was a problem hiding this comment.
the renaming is a breaking change
please first change SPIRVReader in release branches to accept both SPV_INTEL_long_constant_composite and SPV_INTEL_long_composites, then wait for a graceful period and only then proceed with the renaming in ToT
vmaksimo
changed the title
|
Please take a look @asudarsa @LU-JOHN @bwlodarcz @VyacheslavLevytskyy |
|
LGTM |
|
This solves #2261 when built against KhronosGroup/SPIRV-Tools@e03c8f5 and KhronosGroup/SPIRV-Headers@1c6bb27 Please add |
|
Can we please add a TODO in include/LLVMSPIRVExtensions.inc for the required change to happen in the future? Thanks |
MrSidims
pushed a commit
to MrSidims/SPIRV-LLVM-Translator
that referenced
this pull request
Jan 22, 2024
…NTEL capability after Headers change (KhronosGroup#2258) * Bump SPIRV-Headers to 1c6bb2743599e6eb6f37b2969acc0aef812e32e3 * replace internal SPV_INTEL_long_composites ext with the published SPV_INTEL_long_composites * don't rename extension for now This closes: KhronosGroup#2261 Co-authored-by: Wlodarczyk, Bertrand <bertrand.wlodarczyk@intel.com>
MrSidims
added a commit
that referenced
this pull request
Jan 23, 2024
…NTEL capability after Headers change (#2258) (#2308) * Bump SPIRV-Headers to 1c6bb2743599e6eb6f37b2969acc0aef812e32e3 * replace internal SPV_INTEL_long_composites ext with the published SPV_INTEL_long_composites * don't rename extension for now This closes: #2261 Co-authored-by: Viktoria Maximova <viktoria.maksimova@intel.com> Co-authored-by: Wlodarczyk, Bertrand <bertrand.wlodarczyk@intel.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continue #2257
This fixes #2261
The change is needed after KhronosGroup/SPIRV-Registry@5d60c7d and KhronosGroup/SPIRV-Headers@d5acd42