Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(Early version) Implementing spv khr shader clock support #2026

Merged
merged 11 commits into from
Jun 29, 2023
Merged

(Early version) Implementing spv khr shader clock support #2026

merged 11 commits into from
Jun 29, 2023

Conversation

jgstarIntel
Copy link
Contributor

@jgstarIntel jgstarIntel commented May 26, 2023 •
edited by MrSidims
Loading

Early version / progress on spv khr shader clock support & testing.

Specification: https://github.com/KhronosGroup/SPIRV-Registry/blob/main/extensions/KHR/SPV_KHR_shader_clock.asciidoc

@jgstarIntel jgstarIntel marked this pull request as draft May 26, 2023 19:27
@MrSidims
Copy link
Contributor

MrSidims commented Jun 1, 2023

@vmaksimo @asudarsa @maksimsab @LU-JOHN please take a look

MrSidims
MrSidims reviewed Jun 2, 2023
View reviewed changes
Copy link
Contributor

@MrSidims MrSidims left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some initial feedback, in general looks good

Though I'd like to partially withdraw from the review to let other team members to participate in it and see how addition of new extension works in case of pure SPIR-V friendly LLVM IR translation

lib/SPIRV/libSPIRV/SPIRVInstruction.h Outdated Show resolved Hide resolved
lib/SPIRV/libSPIRV/SPIRVNameMapEnum.h Outdated Show resolved Hide resolved
@asudarsa

This comment was marked as outdated.

Sign in to view
asudarsa
asudarsa requested changes Jun 5, 2023
View reviewed changes
Copy link
Contributor

@asudarsa asudarsa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Please address comments and fix formatting issues.

Thanks

@MrSidims
Copy link
Contributor

MrSidims commented Jun 5, 2023 •
edited
Loading

Hi @jgstarIntel

I think we need to update the SPIRV-LLVM-Translator/spirv-headers-tag.conf to pick up a newer SPIR-V Headers that has the required changes for spec. This is the latest commit: 8e2ad27488ed2f87c068c01a8f5e8979f7086405 (in the https://github.com/KhronosGroup/SPIRV-Headers repo). @MrSidims, can you please confirm?

Thanks

The instruction and capability op codes present in spirv.hpp for quite a while. The need to update the headers is not expected by me. But if the build shows otherwise - sure.

@asudarsa
Copy link
Contributor

asudarsa commented Jun 5, 2023

otherwise

Hi @MrSidims
You are right. We do not need to update the headers. @jgstarIntel, please ignore request for update of spirv-headers-tag.conf.

Thanks

@asudarsa
Copy link
Contributor

asudarsa commented Jun 7, 2023

Hi @jgstarIntel

Just FYI. I see two action items here: (1) Fix formatting issues and (2) Fix test fail in extensions/KHR/SPV_KHR_shader_clock/shader_clock.ll

I think there are no other action items based on comments/discussions so far.

Thanks

@jgstarIntel jgstarIntel marked this pull request as ready for review June 9, 2023 23:16
@jgstarIntel
Copy link
Contributor Author

Currently working and passing all tests in my workspace. Will check/rerun as needed to make sure same happens here.

Hi @jgstarIntel

Just FYI. I see two action items here: (1) Fix formatting issues and (2) Fix test fail in extensions/KHR/SPV_KHR_shader_clock/shader_clock.ll

I think there are no other action items based on comments/discussions so far.

Thanks

@jgstarIntel
Copy link
Contributor Author

Hi @AlexeySachkov, can you please check/merge? @asudarsa has suggested we address clang-tidy issue separately since it seems like a known/external issue.

@AlexeySachkov AlexeySachkov merged commit e4dfa92 into KhronosGroup:main Jun 29, 2023
amielcza pushed a commit to amielcza/SPIRV-LLVM-Translator that referenced this pull request Nov 7, 2023
@jgstarIntel @amielcza
Cherry pick of: Implement support for SPV_KHR_shader_clock (KhronosGr…
11d046f 
…oup#2026)

Link to the spec: https://github.com/KhronosGroup/SPIRV-Registry/blob/main/extensions/KHR/SPV_KHR_shader_clock.asciidoc
amielcza pushed a commit to amielcza/SPIRV-LLVM-Translator that referenced this pull request Nov 7, 2023
@jgstarIntel @amielcza
Cherry pick of: Implement support for SPV_KHR_shader_clock (KhronosGr…
87c3592 
…oup#2026)

Link to the spec: https://github.com/KhronosGroup/SPIRV-Registry/blob/main/extensions/KHR/SPV_KHR_shader_clock.asciidoc
amielcza pushed a commit to amielcza/SPIRV-LLVM-Translator that referenced this pull request Nov 7, 2023
@jgstarIntel @amielcza
Implement support for SPV_KHR_shader_clock (KhronosGroup#2026)
0e78d6e 
Link to the spec: https://github.com/KhronosGroup/SPIRV-Registry/blob/main/extensions/KHR/SPV_KHR_shader_clock.asciidoc
amielcza pushed a commit to amielcza/SPIRV-LLVM-Translator that referenced this pull request Nov 7, 2023
@jgstarIntel @amielcza
Implement support for SPV_KHR_shader_clock (KhronosGroup#2026)
b9a55ad 
Link to the spec: https://github.com/KhronosGroup/SPIRV-Registry/blob/main/extensions/KHR/SPV_KHR_shader_clock.asciidoc
MrSidims pushed a commit that referenced this pull request Nov 8, 2023
@amielcza @jgstarIntel
Implement support for SPV_KHR_shader_clock (#2026) (#2206)
8ea71a0 
Link to the spec: https://github.com/KhronosGroup/SPIRV-Registry/blob/main/extensions/KHR/SPV_KHR_shader_clock.asciidoc

Co-authored-by: jgstarIntel <joey.genfi@intel.com>
MrSidims pushed a commit that referenced this pull request Nov 8, 2023
@amielcza @jgstarIntel
[Backport to 14] Implement support for SPV_KHR_shader_clock (#2026) (#…
3b16190 
…2203)

Link to the spec: https://github.com/KhronosGroup/SPIRV-Registry/blob/main/extensions/KHR/SPV_KHR_shader_clock.asciidoc

Co-authored-by: jgstarIntel <joey.genfi@intel.com>
MrSidims pushed a commit that referenced this pull request Nov 8, 2023
@amielcza @jgstarIntel
[Backport to 15] Implement support for SPV_KHR_shader_clock (#2026) (#…
22e6c81 
…2207)

Link to the spec: https://github.com/KhronosGroup/SPIRV-Registry/blob/main/extensions/KHR/SPV_KHR_shader_clock.asciidoc

Co-authored-by: jgstarIntel <joey.genfi@intel.com>
KorovinVlad pushed a commit to KorovinVlad/SPIRV-LLVM-Translator that referenced this pull request Jan 29, 2024
@jgstarIntel @KorovinVlad
[Backport to 13] Implement support for SPV_KHR_shader_clock (KhronosG…
8b0bb55 
…roup#2026)

Link to the spec: https://github.com/KhronosGroup/SPIRV-Registry/blob/main/extensions/KHR/SPV_KHR_shader_clock.asciidoc
KorovinVlad pushed a commit to KorovinVlad/SPIRV-LLVM-Translator that referenced this pull request Jan 29, 2024
@jgstarIntel @KorovinVlad
[Backport to 12] Implement support for SPV_KHR_shader_clock (KhronosG…
15bb577 
…roup#2026)

Link to the spec: https://github.com/KhronosGroup/SPIRV-Registry/blob/main/extensions/KHR/SPV_KHR_shader_clock.asciidoc
KorovinVlad pushed a commit to KorovinVlad/SPIRV-LLVM-Translator that referenced this pull request Jan 29, 2024
@jgstarIntel @KorovinVlad
[Backport to 11] Implement support for SPV_KHR_shader_clock (KhronosG…
6d3c9b3 
…roup#2026)

Link to the spec: https://github.com/KhronosGroup/SPIRV-Registry/blob/main/extensions/KHR/SPV_KHR_shader_clock.asciidoc
KorovinVlad pushed a commit to KorovinVlad/SPIRV-LLVM-Translator that referenced this pull request Jan 30, 2024
@jgstarIntel @KorovinVlad
[Backport to 10] Implement support for SPV_KHR_shader_clock (KhronosG…
683c6fe 
…roup#2026)

Link to the spec: https://github.com/KhronosGroup/SPIRV-Registry/blob/main/extensions/KHR/SPV_KHR_shader_clock.asciidoc
KorovinVlad pushed a commit to KorovinVlad/SPIRV-LLVM-Translator that referenced this pull request Jan 30, 2024
@jgstarIntel @KorovinVlad
[Backport to 9] Implement support for SPV_KHR_shader_clock (KhronosGr…
4ae68bf 
…oup#2026)

Link to the spec: https://github.com/KhronosGroup/SPIRV-Registry/blob/main/extensions/KHR/SPV_KHR_shader_clock.asciidoc
KorovinVlad pushed a commit to KorovinVlad/SPIRV-LLVM-Translator that referenced this pull request Jan 30, 2024
@jgstarIntel @KorovinVlad
[Backport to 10] Implement support for SPV_KHR_shader_clock (KhronosG…
b252ae4 
…roup#2026)

Link to the spec: https://github.com/KhronosGroup/SPIRV-Registry/blob/main/extensions/KHR/SPV_KHR_shader_clock.asciidoc
KorovinVlad pushed a commit to KorovinVlad/SPIRV-LLVM-Translator that referenced this pull request Jan 30, 2024
@jgstarIntel @KorovinVlad
[Backport to 10] Implement support for SPV_KHR_shader_clock (KhronosG…
6fd6ae3 
…roup#2026)

Link to the spec: https://github.com/KhronosGroup/SPIRV-Registry/blob/main/extensions/KHR/SPV_KHR_shader_clock.asciidoc
KorovinVlad pushed a commit to KorovinVlad/SPIRV-LLVM-Translator that referenced this pull request Jan 30, 2024
@jgstarIntel @KorovinVlad
[Backport to 9] Implement support for SPV_KHR_shader_clock (KhronosGr…
6b05238 
…oup#2026)

Link to the spec: https://github.com/KhronosGroup/SPIRV-Registry/blob/main/extensions/KHR/SPV_KHR_shader_clock.asciidoc
KorovinVlad pushed a commit to KorovinVlad/SPIRV-LLVM-Translator that referenced this pull request Jan 31, 2024
@jgstarIntel @KorovinVlad
[Backport to 9] Implement support for SPV_KHR_shader_clock (KhronosGr…
2abf6a2 
…oup#2026)

Link to the spec: https://github.com/KhronosGroup/SPIRV-Registry/blob/main/extensions/KHR/SPV_KHR_shader_clock.asciidoc
MrSidims pushed a commit that referenced this pull request Jan 31, 2024
@KorovinVlad @jgstarIntel
[Backport to 13] Implement support for SPV_KHR_shader_clock (#2026) (#…
b360fac 
…2319)

Link to the spec: https://github.com/KhronosGroup/SPIRV-Registry/blob/main/extensions/KHR/SPV_KHR_shader_clock.asciidoc

Co-authored-by: jgstarIntel <joey.genfi@intel.com>
MrSidims pushed a commit that referenced this pull request Jan 31, 2024
@KorovinVlad @jgstarIntel
[Backport to 12] Implement support for SPV_KHR_shader_clock (#2026) (#…
b257b75 
…2320)

Link to the spec: https://github.com/KhronosGroup/SPIRV-Registry/blob/main/extensions/KHR/SPV_KHR_shader_clock.asciidoc

Co-authored-by: jgstarIntel <joey.genfi@intel.com>
MrSidims pushed a commit that referenced this pull request Jan 31, 2024
@KorovinVlad @jgstarIntel
[Backport to 11] Implement support for SPV_KHR_shader_clock (#2026) (#…
2e025e4 
…2321)

Link to the spec: https://github.com/KhronosGroup/SPIRV-Registry/blob/main/extensions/KHR/SPV_KHR_shader_clock.asciidoc

Co-authored-by: jgstarIntel <joey.genfi@intel.com>
MrSidims pushed a commit that referenced this pull request Feb 1, 2024
@KorovinVlad @jgstarIntel
[Backport to 10] Implement support for SPV_KHR_shader_clock (#2026) (#…
fe87ee7 
…2328)

Link to the spec: https://github.com/KhronosGroup/SPIRV-Registry/blob/main/extensions/KHR/SPV_KHR_shader_clock.asciidoc

Co-authored-by: jgstarIntel <joey.genfi@intel.com>
KorovinVlad pushed a commit to KorovinVlad/SPIRV-LLVM-Translator that referenced this pull request Feb 1, 2024
@jgstarIntel @KorovinVlad
[Backport to 9] Implement support for SPV_KHR_shader_clock (KhronosGr…
56c9251 
…oup#2026)

Link to the spec: https://github.com/KhronosGroup/SPIRV-Registry/blob/main/extensions/KHR/SPV_KHR_shader_clock.asciidoc
MrSidims pushed a commit that referenced this pull request Feb 2, 2024
@KorovinVlad @jgstarIntel
[Backport to 9] Implement support for SPV_KHR_shader_clock (#2026) (#…
9caf18b 
…2329)

Link to the spec: https://github.com/KhronosGroup/SPIRV-Registry/blob/main/extensions/KHR/SPV_KHR_shader_clock.asciidoc

Co-authored-by: jgstarIntel <joey.genfi@intel.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MrSidims MrSidims MrSidims left review comments

@asudarsa asudarsa asudarsa requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jgstarIntel @MrSidims @asudarsa @AlexeySachkov