Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

loader: Fix filename and native lib dir sequence for log #311

Merged
merged 2 commits into from
May 31, 2022

Conversation

utzcoz
Copy link
Contributor

@utzcoz utzcoz commented May 30, 2022

No description provided.

Signed-off-by: utzcoz <utzcoz@outlook.com>
@utzcoz
Copy link
Contributor Author

utzcoz commented May 30, 2022

Hi @rpavlik , could you help to review this PR? Thanks.

@rpavlik
Copy link
Contributor

rpavlik commented May 30, 2022

Looks good, can you add a changelog fragment in changes/sdk? See readme in there

Signed-off-by: utzcoz <utzcoz@outlook.com>
@utzcoz
Copy link
Contributor Author

utzcoz commented May 31, 2022

Looks good, can you add a changelog fragment in changes/sdk? See readme in there

Hi @rpavlik , I added a new commit to add changelog fragment based on previous PRs. If it doesn't meet requirement, please let me know.

Copy link
Contributor

@rpavlik rpavlik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks!

@rpavlik rpavlik merged commit 915196a into KhronosGroup:main May 31, 2022
@utzcoz utzcoz deleted the fix-log branch May 31, 2022 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants