Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove draft state for loader spec #300

Merged

Conversation

utzcoz
Copy link
Contributor

@utzcoz utzcoz commented Apr 2, 2022

The OpenXR-SDK-Source has implemented and used new loader based on this spec for OpenXR apps. The loader implementation based on this spec has been released to normal users multiple version. IMO, it's time to remove draft state from spec title.

cc @rpavlik .

Signed-off-by: utzcoz <utzcoz@outlook.com>
@utzcoz utzcoz force-pushed the remove-draft-state-for-loader-spec branch from ea35461 to 4be38af Compare April 2, 2022 04:52
@utzcoz
Copy link
Contributor Author

utzcoz commented Apr 2, 2022

Looks like Azure CI has problem when initializing build tools:

Generating script.
========================== Starting Command Output ===========================
"C:\Windows\system32\cmd.exe" /D /E:ON /V:OFF /S /C "CALL "D:\a\_temp\7b35feca-b8bd-4b2f-9bc9-31c773233dce.cmd""
CMake Error at CMakeLists.txt:25 (project):
  Generator

    Visual Studio 16 2019

  could not find any instance of Visual Studio.



-- Configuring incomplete, errors occurred!
See also "D:/a/1/s/build/CMakeFiles/CMakeOutput.log".
##[error]Cmd.exe exited with code '1'.
Finishing: Generate build system

It's not related to this PR's changes.

@rpavlik-bot
Copy link
Collaborator

An issue (number 1688) has been filed to correspond to this pull request in the internal Khronos GitLab (Khronos members only: KHR:openxr/openxr#1688 ), to facilitate working group processes.

This GitHub pull request will continue to be the main site of discussion.

@rpavlik-bot rpavlik-bot added the synced to gitlab Synchronized to OpenXR internal GitLab label Apr 7, 2022
@rpavlik
Copy link
Contributor

rpavlik commented Apr 7, 2022

Thanks for this! Group agrees this was an oversight. Approved to merge, I'll just have to figure out what happened to ci.

@rpavlik rpavlik merged commit f680f8d into KhronosGroup:main Apr 18, 2022
@utzcoz utzcoz deleted the remove-draft-state-for-loader-spec branch April 18, 2022 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
synced to gitlab Synchronized to OpenXR internal GitLab
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants