Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix payload value query for external semaphores #2127

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix payload value query for external semaphores #2127

wants to merge 1 commit into from

Commits on Oct 24, 2024

  1. Fix payload value query for external semaphores 

    When creating a CL semaphore object from a Vulkan semaphore one, we
explicitly pass `-1` as the file descriptor value in the case of
`VULKAN_EXTERNAL_SEMAPHORE_HANDLE_TYPE_SYNC_FD`. According to the CL
specification:

    The special value -1 for fd is treated like a valid sync file
    descriptor referring to an object that has already signaled. The
    import operation will succeed and the semaphore will have a
    temporarily imported payload as if a valid file descriptor had
    been provided.

The test currently checks that the semaphore payload is unsignalled,
unconditionally, which is incorrect.

Changed the test to check for the correct expected payload value.

Signed-off-by: Ahmed Hesham <ahmed.hesham@arm.com>
    @ahesham-arm
    ahesham-arm committed Oct 24, 2024
    Configuration menu
    Copy the full SHA
    933bf66 View commit details
    Browse the repository at this point in the history