Update syntax highlighting #254
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This Cl switches to the `rouge` highlighter which matches the Vulkan spec. The `rouge-extended-css.rb` file is copied in from the Vulkan-Docs repo. The code examples are updated to use `source,glsl` instead of `source,c++`. This means when mousing over the code blocks in the HTML version the syntax will correctly be identified as GLSL.
|
Consistency with Vulkan is good and having the code identified correctly in the HTML is also good. Thanks for doing this. When I build with this branch, though, the highlighting doesn't look as good as in the Vulkan spec and not quite as good as without this change (too many bold typefaces and bright colours). I'll try to track down the difference and we can merge this. Do you get consistency with the Vulkan spec when you build from this branch? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This Cl switches to the
rougehighlighter which matches the Vulkan spec. Therouge-extended-css.rbfile is copied in from the Vulkan-Docs repo.The code examples are updated to use
source,glslinstead ofsource,c++. This means when mousing over the code blocks in the HTML version the syntax will correctly be identified as GLSL.