Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow MPI command output to be verbose for OpenMPI #310

Closed
popescu-v opened this issue Jun 20, 2024 · 7 comments · Fixed by #393
Closed

Allow MPI command output to be verbose for OpenMPI #310

popescu-v opened this issue Jun 20, 2024 · 7 comments · Fixed by #393
Assignees
Labels
Priority/1 To do after P0

Comments

@popescu-v
Copy link
Collaborator

Description

Currently, the --quiet flag is added to the mpiexec command in the khiops-env script on Linux platforms, which utilize OpenMPI for native installations.

The goal of this issue is to add an environment variable KHIOPS_MPI_VERBOSE, which is set to "false" by default and, if set to "true", would remove the --quiet flag.

Thusly, MPI-related errors could be checked on demand.

popescu-v added a commit to KhiopsML/khiops-python that referenced this issue Jun 20, 2024
popescu-v added a commit to KhiopsML/khiops-python that referenced this issue Jun 20, 2024
popescu-v added a commit to KhiopsML/khiops-python that referenced this issue Jun 20, 2024
popescu-v added a commit to KhiopsML/khiops-python that referenced this issue Jun 20, 2024
@folmos-at-orange
Copy link
Member

folmos-at-orange commented Jun 21, 2024

I'd call it KHIOPS_MPI_QUIET because there is an --verbose option in OpenMPI in addition to --quiet.

popescu-v added a commit to KhiopsML/khiops-python that referenced this issue Jun 24, 2024
popescu-v added a commit to KhiopsML/khiops-python that referenced this issue Jun 24, 2024
@popescu-v
Copy link
Collaborator Author

I'd call it KHIOPS_MPI_QUIET because there is an --verbose option in OpenMPI in addition to --quiet.

One argument for the current KHIOPS_MPI_VERBOSE would be that, depending on the MPI back-end, this verbosity might mean different things:

  • for OpenMPI, which is the default back-end for native installations on Linux (but can be overridden via the KHIOPS_MPI_COMMAND and KHIOPS_MPI_LIB environment variables) we define this as being a switch on the --quiet flag (and this might change in the future - perhaps by combining it with the --verbose flag ? @bruno-at-orange ?)
  • for MPICH (possible alternative back-end on some platforms - e.g. khiops-core on Conda), this does nothing currently, but could do in the future,
  • etc.

@bruno-at-orange
Copy link
Contributor

The first proposal is fine: KHIOPS_MPI_VERBOSE which is set to "false" by default

@folmos-at-orange
Copy link
Member

  • What happens if it is not defined in the environment? It acts as a if it were false ?
  • What happens if it is defined values other than true and false ?

@popescu-v
Copy link
Collaborator Author

popescu-v commented Jun 24, 2024

  • What happens if it is not defined in the environment? It acts as a if it were false ?

I would say "yes".

* What happens if it is defined values other than `true` and `false` ?

I would say anything != true acts like false.

@folmos-at-orange
Copy link
Member

folmos-at-orange commented Jun 25, 2024

Ok, @bruno-at-orange do you confirm the behavior above ?

@popescu-v
Copy link
Collaborator Author

My understading is that in khiops-env the KHIOPS_MPI_VERBOSE variable is set to "false" by default (that is, if it is not already defined in the environment). If this variable's value is different from "true" (which includes the default "false" or whatever the user has set), then --quiet is added to mpiexec. If this variable's value equals "true", then the --quiet flag is not added to mpiexec.

Is this also your understanding @bruno-at-orange ?

@alexisbondu alexisbondu added the Priority/1 To do after P0 label Jun 27, 2024
popescu-v added a commit to KhiopsML/khiops-python that referenced this issue Jun 28, 2024
Honor issue KhiopsML/khiops#310

To be merged after the issue mentioned above is addressed upstream.
popescu-v added a commit to KhiopsML/khiops-python that referenced this issue Jun 28, 2024
Honor issue KhiopsML/khiops#310

To be merged after the issue mentioned above is addressed upstream.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority/1 To do after P0
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants