Lint failing on 1.21+ #313
Comments
benjaminjkraft
added a commit
that referenced
this issue
Feb 15, 2024
We weren't pinning the Go version for golangci-lint (only the golangci-lint version); seemingly it breaks on 1.21+. Now we're using a new version making it easy to pin back to 1.20. Later I'll look at why 1.21+ are failing (#313). While I was at it I added tests on 1.21 (1.22+ is failing, again will look later, #312), and upgraded the setup-go action itself. I have: - [x] Written a clear PR title and description (above) - [x] Signed the [Khan Academy CLA](https://www.khanacademy.org/r/cla) - [x] Added tests covering my changes, if applicable (n/a) - [x] Included a link to the issue fixed, if applicable (n/a) - [x] Included documentation, for new features (n/a) - [x] Added an entry to the changelog (n/a)
6 tasks
benjaminjkraft
added a commit
that referenced
this issue
Feb 15, 2024
Apparently our version of golangci-lint didn't work with Go 1.21+ on our codebase. A newer version does, which required redoing the `depguard` config (I think it's equivalent to what we had) and one tweak for the benefit of `gocritic`. Fixes #313. I have: - [x] Written a clear PR title and description (above) - [x] Signed the [Khan Academy CLA](https://www.khanacademy.org/r/cla) - [x] Added tests covering my changes, if applicable (n/a) - [x] Included a link to the issue fixed, if applicable - [x] Included documentation, for new features (n/a) - [x] Added an entry to the changelog (n/a)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Not sure what's up but we'll need to fix it. We can probably also upgrade golangci-lint while we're at it.
The text was updated successfully, but these errors were encountered: